Hi Bruce, > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, November 24, 2015 4:14 PM > To: Iremonger, Bernard <bernard.iremonger at intel.com> > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/1] app/test: create ring and ethdevs in > pmd_ring_autotest > > On Mon, Nov 23, 2015 at 03:20:46PM +0000, Bernard Iremonger wrote: > > Use command line option --vdev=eth_ring0 to create port 0. > > Create two rings and five ethdevs in test_pmd_ring for ports 1 to 5. > > Improve test output by adding the port number to printf statements, > > and adding a printf describing each test. > > > > revise ring-based PMD doc to match latest ring PMD code. > > > > Signed-off-by: Bernard Iremonger <bernard.iremonger at intel.com> > > The doc changes are not relevant to the unit test fixes, so should be in a > separate patch. The test changes themselves are good though, and actually > makes the test runable without having to find a very specific command-line > incantation to make things work right. > > Subject to this being split into two: > Acked-by: Bruce Richardson <bruce.richardson at intel.com>
Will I keep your ack on both patches when I split them? Regards, Bernard. <snip>