On 10/6/2021 12:06 PM, Ferruh Yigit wrote: > On 10/1/2021 10:07 AM, Andrew Rybchenko wrote: >> All xstats names may be retrieved passing NULL ids. >> >> If a driver does not support getting names by IDs, the callback should >> return -ENOTSUP on attempt to use it. If so, the request is handled >> on ethdev layer by getting all names and filtering out requested only. >> >> Signed-off-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > > The intention is to simplify dev_ops for drivers and have one less dev_ops, > but for xstat_by_id, it is already covered by ethdev layer if PMD doesn't > implement one, so PMD needs to implement them only if it has a better way > to provide _by_id values. > > So this merge is bringing an additional check for the ones that doesn't > implement _by_id dev_ops, and for the ones that implement there isn't much > difference, still PMD needs two functions, one for to get all values, and > one for to get _by_id, now although there is single dev_ops, PMD > implementation > doesn't differ much. > > Because of above reasons I am not sure about this patch, let me proceed > with > rest of the series, we can discuss this patch more separately. >
The patch is in patchwork for a long time, there was no new comment/discussion, I am updating it as rejected. Please send a new version if you want to pursue the optimization more.
