> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Thursday, June 1, 2023 4:50 PM > To: Richardson, Bruce <bruce.richard...@intel.com>; Tyler Retzlaff > <roret...@linux.microsoft.com> > Cc: dev@dpdk.org; tho...@monjalon.net; Zhang, Qi Z > <qi.z.zh...@intel.com> > Subject: Re: [PATCH 0/6] windows: remove most pthread lifetime shim > functions > > On Tue, Apr 18, 2023 at 11:21 AM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > > On Sun, Apr 02, 2023 at 10:34:12PM -0700, Tyler Retzlaff wrote: > > > early review if possible please, would like to have this in from the > > > start of 23.07 to work against. > > > > > > thanks! > > > > > > > Don't see any problems with this set. > > Drivers maintainers were not copied (Tyler, git send-email has options --to- > cmd or --cc-cmd to which you can pass ./devtools/get-maintainers.sh). > I pinged Qi during the maintainers call today.
Hi Tyler & David: The patchset looks good to me. I have just one question regarding the patch set targets, which include PMD iavf, ice, and ixgbe. However, I noticed that some other Intel PMDs like ipn3ke still use rte_ctrl_thread_create and have not been replaced. I assume that this replacement is specifically intended for PMDs that support Windows, as PMDs with the "Windows" feature should be covered. However, I didn't see the "Windows" feature enabled for iavf PMD, even though it is included in the patch set. Could you help me understand the criteria used for determining which PMDs should be included in this replacement? Thanks Qi > > The changes are straightforward and lgtm. > For the series, > Reviewed-by: David Marchand <david.march...@redhat.com> > > > -- > David Marchand
