> -----Original Message-----
> From: Wu, Jingjing
> Sent: Monday, November 23, 2015 1:54 PM
> To: Zhang, Helin; dev at dpdk.org
> Cc: Pei, Yulong
> Subject: RE: [PATCH] i40e: fix issue of reconfigure hash enable flags
>
> >
> > - if (!key || key_len != ((I40E_PFQF_HKEY_MAX_INDEX + 1) *
> > - sizeof(uint32_t)))
> > + if (!key || key_len == 0) {
> > + PMD_DRV_LOG(DEBUG, "No key to be configured");
> > + return 0;
> > + } else if (key && (key_len != (I40E_PFQF_HKEY_MAX_INDEX + 1) *
> > + sizeof(uint32_t))) {
> No need to check key in else if, it shouldn't be NULL here.
Yes, it should be removed. Thanks!
Regards,
Helin
> > + PMD_DRV_LOG(ERR, "Invalid key length %u", key_len);
> > return -EINVAL;
> > + }
>
> Thanks
> Jingjing
