On Wed, May 31, 2023 at 4:25 PM Pavan Nikhilesh Bhagavatula
<pbhagavat...@marvell.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Srujana Challa <scha...@marvell.com>
> > Sent: Wednesday, May 31, 2023 4:03 PM
> > To: Pavan Nikhilesh Bhagavatula <pbhagavat...@marvell.com>; Shijith
> > Thotton <sthot...@marvell.com>; Rahul Bhansali <rbhans...@marvell.com>;
> > Jerin Jacob Kollanukkaran <jer...@marvell.com>
> > Cc: dev@dpdk.org; Srujana Challa <scha...@marvell.com>; Nithin Kumar
> > Dabilpuram <ndabilpu...@marvell.com>
> > Subject: [PATCH v2] event/cnxk: fix LMTST write for single event mode
> >
> > LMTST area can be overwritten before read by HW between to consecutive
> > steorl operations. Hence, add wmb() after steorl op to make sure
> > the LMTST operation is complete.
> >
> > Fixes: 313e884a22fd ("event/cnxk: support Tx adapter fast path")
> > Cc: pbhagavat...@marvell.com
> >
> > Signed-off-by: Srujana Challa <scha...@marvell.com>
>
> Acked-by: Pavan Nikhilesh <pbhagavat...@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
>
> > ---
> > drivers/event/cnxk/cn10k_tx_worker.h | 8 +++-----
> > 1 file changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/event/cnxk/cn10k_tx_worker.h
> > b/drivers/event/cnxk/cn10k_tx_worker.h
> > index c18786a14c..81fe31c4b9 100644
> > --- a/drivers/event/cnxk/cn10k_tx_worker.h
> > +++ b/drivers/event/cnxk/cn10k_tx_worker.h
> > @@ -43,7 +43,6 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct
> > rte_mbuf *m, uint64_t *cmd,
> > const uint64_t *txq_data, const uint32_t flags)
> > {
> > uint8_t lnum = 0, loff = 0, shft = 0;
> > - uint16_t ref_cnt = m->refcnt;
> > struct cn10k_eth_txq *txq;
> > uintptr_t laddr;
> > uint16_t segdw;
> > @@ -98,10 +97,9 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct
> > rte_mbuf *m, uint64_t *cmd,
> >
> > roc_lmt_submit_steorl(lmt_id, pa);
> >
> > - if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) {
> > - if (ref_cnt > 1)
> > - rte_io_wmb();
> > - }
> > + /* Memory barrier to make sure lmtst store completes */
> > + rte_io_wmb();
> > +
> > return 1;
> > }
> >
> > --
> > 2.25.1
>
