> -----Original Message----- > From: Miao Li <[email protected]> > Sent: Thursday, May 25, 2023 10:01 PM > To: [email protected] > Cc: Sunil Kumar Kori <[email protected]>; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; Anatoly Burakov > <[email protected]> > Subject: [EXT] [PATCH v3 2/4] bus/pci: avoid depending on private value in > kernel source > > External Email > > ---------------------------------------------------------------------- > From: Chenbo Xia <[email protected]> > > The value 40 used in VFIO_GET_REGION_ADDR() is a private value > (VFIO_PCI_OFFSET_SHIFT) defined in Linux kernel source [1]. It is not part of > VFIO API, and we should not depend on it. > > [1] https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_torvalds_linux_blob_v6.2_include_linux_vfio-5Fpci- > 5Fcore.h&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=dXeXaAMkP5COgn1z > xHMyaF1_d9IIuq6vHQO6NrIPjaE&m=JmiGBKn8A8yznTdPB1knOyEeYM4moYy > ws5F5wylRMz9_Jp8-FRr- > _FDWaUpA6a7U&s=DBgE0M81mcB0EWqXuq8apKbHmhKQIQ52RFcPWdHXat > s&e= > > Signed-off-by: Chenbo Xia <[email protected]> > --- > drivers/bus/pci/linux/pci.c | 4 +- > drivers/bus/pci/linux/pci_init.h | 4 +- > drivers/bus/pci/linux/pci_vfio.c | 197 +++++++++++++++++++++++-------- > drivers/bus/pci/private.h | 9 ++ > lib/eal/include/rte_vfio.h | 1 - > 5 files changed, 159 insertions(+), 56 deletions(-) > Acked-by: Sunil Kumar Kori <[email protected]>
... [snipped] ... > 2.25.1
