Hi Sunyang,
> Hi Akhil,
> The patches have been resubmitted.
Yeah they are resubmitted, but you should mark them as v2
And mention the changelog as well.
I can see that all the comments were not addressed.
Please add release notes.
The update to crypto_auth/cipher_algorithm_strings is also missing.
>
> Best wishes
> sunyang
>
> -----Original Message-----
> From: Akhil Goyal <gak...@marvell.com>
> Send: 2023.5.25 16:27 PM
> To: Akhil Goyal <gak...@marvell.com>; Sunyang Wu
> <sunyang...@jaguarmicro.com>; dev@dpdk.org
> Cc: kai...@intel.com
> Subject: RE: [EXT] [PATCH 1/2] lib/cryptodev/: Add
> SM3_HMAC/SM4_CFB/SM4_OFB support in DPDK
>
> Hi Sunyang,
>
> Can you send the next version for this patch?
> We need to merge in RC1 (31st May).
>
>
> > Subject: RE: [EXT] [PATCH 1/2] lib/cryptodev/: Add
> > SM3_HMAC/SM4_CFB/SM4_OFB support in DPDK
> >
> > > Add SM3_HMAC/SM4_CFB/SM4_OFB support in DPDK.
> > >
> > > Signed-off-by: Sunyang Wu <sunyang...@jaguarmicro.com>
> > > ---
> > > lib/cryptodev/rte_crypto_sym.h | 8 +++++++-
> > > 1 file changed, 7 insertions(+), 1 deletion(-)
> > >
> >
> > Please add release notes and update
> > doc/guides/cryptodevs/features/default.ini.
> >
> > The update to crypto_auth/cipher_algorithm_strings is also missing.
> >
> > > diff --git a/lib/cryptodev/rte_crypto_sym.h
> > > b/lib/cryptodev/rte_crypto_sym.h index 2cfe66530c..c4572106dc 100644
> > > --- a/lib/cryptodev/rte_crypto_sym.h
> > > +++ b/lib/cryptodev/rte_crypto_sym.h
> > > @@ -172,8 +172,12 @@ enum rte_crypto_cipher_algorithm {
> > > /**< ShangMi 4 (SM4) algorithm in ECB mode */
> > > RTE_CRYPTO_CIPHER_SM4_CBC,
> > > /**< ShangMi 4 (SM4) algorithm in CBC mode */
> > > - RTE_CRYPTO_CIPHER_SM4_CTR
> > > + RTE_CRYPTO_CIPHER_SM4_CTR,
> > > /**< ShangMi 4 (SM4) algorithm in CTR mode */
> > > + RTE_CRYPTO_CIPHER_SM4_OFB,
> > > + /**< ShangMi 4 (SM4) algorithm in OFB mode */
> > > + RTE_CRYPTO_CIPHER_SM4_CFB
> > > + /**< ShangMi 4 (SM4) algorithm in CFB mode */
> > > };
> > >
> > > /** Cipher algorithm name strings */ @@ -376,6 +380,8 @@ enum
> > > rte_crypto_auth_algorithm {
> > > /**< HMAC using 512 bit SHA3 algorithm. */
> > > RTE_CRYPTO_AUTH_SM3,
> > > /**< ShangMi 3 (SM3) algorithm */
> > > + RTE_CRYPTO_AUTH_SM3_HMAC,
> > > + /** < HMAC using Chinese SM3 algorithm */
> > >
> > > RTE_CRYPTO_AUTH_SHAKE_128,
> > > /**< 128 bit SHAKE algorithm. */
> > > --
> > > 2.19.0.rc0.windows.1
