On Tue, May 9, 2023 at 11:34 AM Zhirun Yan <zhirun....@intel.com> wrote:
>
> Add new get/set APIs to configure graph worker model which is used to
> determine which model will be chosen.
>
> Signed-off-by: Haiyue Wang <haiyue.w...@intel.com>
> Signed-off-by: Cunming Liang <cunming.li...@intel.com>
> Signed-off-by: Zhirun Yan <zhirun....@intel.com>
> ---
> diff --git a/lib/graph/rte_graph_worker.c b/lib/graph/rte_graph_worker.c
> new file mode 100644
> index 0000000000..cabc101262
> --- /dev/null
> +++ b/lib/graph/rte_graph_worker.c
> @@ -0,0 +1,54 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(C) 2023 Intel Corporation
> + */
> +
> +#include "rte_graph_worker_common.h"
> +
> +RTE_DEFINE_PER_LCORE(enum rte_graph_worker_model, worker_model) =
> RTE_GRAPH_MODEL_DEFAULT;
> +
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
> + * Set the graph worker model
Just declaring this top of the header file enough to avoid duplicating
in every functions
as all functions in header is experimental. See lib/graph/rte_graph.h
> + *
> + * @note This function does not perform any locking, and is only safe to call
> + * before graph running.
> + *
> + * @param name
> + * Name of the graph worker model.
> + *
> + * @return
> + * 0 on success, -1 otherwise.
> + */
> +int
> +rte_graph_worker_model_set(enum rte_graph_worker_model model)
> +{
> + if (model >= RTE_GRAPH_MODEL_LIST_END)
> + goto fail;
> +
> + RTE_PER_LCORE(worker_model) = model;
Application needs to set this per core . Right?
Are we anticipating a case where one core runs one model and another
core runs with another model?
If not OR it is not practically possible, then, To make application
programmer life easy,
We could loop through all lore and set on all of them instead of
application setting on each
one separately.
> + return 0;
> +
> +fail:
> + RTE_PER_LCORE(worker_model) = RTE_GRAPH_MODEL_DEFAULT;
> + return -1;
> +}
> +
> +/** Graph worker models */
> +enum rte_graph_worker_model {
> + RTE_GRAPH_MODEL_DEFAULT,
Add Doxygen comment
> + RTE_GRAPH_MODEL_RTC = RTE_GRAPH_MODEL_DEFAULT,
Add Doxygen comment to explain what this mode does.
> + RTE_GRAPH_MODEL_MCORE_DISPATCH,
Add Doxygen comment to explain what this mode does.
> + RTE_GRAPH_MODEL_LIST_END
This can break the ABI if we add one in middle. Please remove this.
See lib/crytodev for
how to handle with _END symbols.
