On 5/16/2023 6:32 PM, Joshua Washington wrote: > Hello, > > I believe my original solution was something closer to what you are > suggesting for backward compatibility. I originally had a flag that > enabled changing source port instead of source IP addresses, but I > received feedback that adding an extra flag was complicating things too > much from Stephen. > > On a VM, the purpose of using multi-flow is similar to that of bare > metal: to test RSS in the RX side. However, generating traffic by > changing source IP address can cause inconsistencies in performance due > to protections in cloud infrastructure from sending packets from a > different source IP address than is provisioned for the VM. Changing > source UDP port to test RSS should be functionally equivalent while > allowing VMs to send traffic from a single source IP address. > > If everyone agrees that adding --txonly-multi-flow as an option as well > as keeping the flag is an acceptable way of moving forward, I can do that. >
Hi Joshua, I missed the first version of the patch and the comment, thinking twice comment has a point, I was thinking some users doing RSS based on IP but probably all supports RSS based on UDP too. Better to keep simple. Lets proceed with latest version, I will put some comments on it. Thanks, Ferruh
