> -----Original Message-----
> From: Jie Hai <haij...@huawei.com>
> Sent: Tuesday, May 9, 2023 9:29 AM
> To: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>; Konstantin Ananyev
> <konstantin.v.anan...@yandex.ru>; Ruifeng Wang <ruifeng.w...@arm.com>; Gavin
> Hu
> <gavin...@arm.com>; Olivier Matz <olivier.m...@6wind.com>; Dharmik Jayesh
> Thakkar
> <dharmikjayesh.thak...@arm.com>
> Cc: dev@dpdk.org; liudongdo...@huawei.com
> Subject: [PATCH v5 1/3] ring: fix unmatched type definition and usage
>
> Field 'flags' of struct rte_ring is defined as int type. However, it is used
> as unsigned
> int. To ensure consistency, change the type of flags to unsigned int. Since
> these two
> types has the same byte size, this change is not an ABI change.
>
> Fixes: cc4b218790f6 ("ring: support configurable element size")
The change looks good.
However, I think the fix line is not accurate.
I suppose it fixes af75078fece3 ("first public release").
>
> Signed-off-by: Jie Hai <haij...@huawei.com>
> Acked-by: Konstantin Ananyev <konstantin.v.anan...@yandex.ru>
> Acked-by: Chengwen Feng <fengcheng...@huawei.com>
> ---
> lib/ring/rte_ring_core.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h index
> 82b237091b71..1c809abeb531 100644
> --- a/lib/ring/rte_ring_core.h
> +++ b/lib/ring/rte_ring_core.h
> @@ -120,7 +120,7 @@ struct rte_ring_hts_headtail { struct rte_ring {
> char name[RTE_RING_NAMESIZE] __rte_cache_aligned;
> /**< Name of the ring. */
> - int flags; /**< Flags supplied at creation. */
> + uint32_t flags; /**< Flags supplied at creation. */
> const struct rte_memzone *memzone;
> /**< Memzone, if any, containing the rte_ring */
> uint32_t size; /**< Size of ring. */
> --
> 2.33.0
