On 5/8/2023 7:23 AM, Rushil Gupta wrote: >>> +#ifndef _GVE_VERSION_H_ >>> +#define _GVE_VERSION_H_ >>> + >>> +#include <rte_version.h> >>> + >>> +#define GVE_VERSION_PREFIX "DPDK-" >>> +#define GVE_VERSION_MAJOR 1 >>> +#define GVE_VERSION_MINOR 0 >>> +#define GVE_VERSION_SUB 0 >>> + >> Is this GVE base version, or DPDK gve version? >> Previous version information was "GVE-1.3.0", now it is becoming >> "DPDK-1.0.0", >> is this breaking the version link with GVE base version and creating a >> new versioning scheme for DPDK GVE driver? >> >> Btw, documentation still has "v1.3.0. GVE base code", should it be >> updated as well? >> > DPDK-1.0.0 is the DPDK driver version. GVE driver versioning only > applies for linux kernel Gvnic driver. > Similarly Windows Gvnic driver has different versioning system.
So creating a new versioning scheme for DPDK driver, I guess that is OK. Since there is a new version, is it clear how to manage the versioning, like when to update major version and when to update minor etc? If so can you please document this? And base code is still coming from the Linux kernel driver, I wonder if a mapping between versions of these two is required. As mentioned "v1.3.0" is still in the documentation, what happens if base code updated and some relevant update is required in the dpdk driver code? How to record/manage this? Some drivers records the base code version in a readme file in the base folder, maybe same can be done.
