> -----Original Message-----
> From: [email protected] <[email protected]>
> Sent: Thursday, May 4, 2023 16:54
> To: [email protected]; Wu, Jingjing <[email protected]>; Guo, Junfeng
> <[email protected]>; Li, Xiaoyun <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; Jerin Jacob <[email protected]>;
> [email protected]; Ali Alnubani <[email protected]>
> Subject: [dpdk-dev] [PATCH v2] examples/ntb: fix build issue with GCC 13
>
> From: Jerin Jacob <[email protected]>
>
> Fix the following build issue by not allowing nb_ids to be zero.
> nb_ids can be zero based on rte_rawdev_xstats_get() API
> documentation but it is not valid for the case when second
> argument is NULL.
>
> examples/ntb/ntb_fwd.c: In function 'ntb_stats_display':
> examples/ntb/ntb_fwd.c:945:23: error: 'rte_rawdev_xstats_get'
> accessing 8 bytes in a region of size 0 [-Werror=stringop-overflow=]
> 945 | if (nb_ids != rte_rawdev_xstats_get(dev_id, ids, values, nb_ids)) {
> |
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> examples/ntb/ntb_fwd.c:945:23: note: referencing argument 3
> of type 'uint64_t[0]' {aka 'long unsigned int[]'}
> In file included from ../examples/ntb/ntb_fwd.c:17:
> lib/rawdev/rte_rawdev.h:504:1: note: in a call to function
> 'rte_rawdev_xstats_get'
> 504 | rte_rawdev_xstats_get(uint16_t dev_id,
>
> Fixes: 5194299d6ef5 ("examples/ntb: support more functions")
> Cc: [email protected]
> Signed-off-by: Jerin Jacob <[email protected]>
> Tested-by: Ali Alnubani <[email protected]>
> ---
> v2:
> - Apply the same fix for ntb_stats_clear()(Junfeng)
>
> examples/ntb/ntb_fwd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c
> index f9abed28e4..585aad9d70 100644
> --- a/examples/ntb/ntb_fwd.c
> +++ b/examples/ntb/ntb_fwd.c
> @@ -865,7 +865,7 @@ ntb_stats_clear(void)
> --
> 2.40.1
LGTM, it makes sense to avoid zero memory allocation. Thanks!
Acked-by: Junfeng Guo <[email protected]>
Regards,
Junfeng Guo
