> -----Original Message----- > From: Mcnamara, John > Sent: Wednesday, November 18, 2015 6:40 PM > To: Wang, Zhihong <zhihong.wang at intel.com>; dev at dpdk.org > Subject: RE: [dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary > hugepage zero-filling > > > > > -----Original Message----- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhihong Wang > > Sent: Wednesday, November 18, 2015 3:27 AM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary > > hugepage zero-filling > > > > The kernel fills new allocated (huge) pages with zeros. > > DPDK just has to touch the pages to trigger the allocation. > > > > ... > > if (orig) { > > hugepg_tbl[i].orig_va = virtaddr; > > - memset(virtaddr, 0, hugepage_sz); > > + memset(virtaddr, 0, 8); > > } > > Probably worth adding a one or two line comment here to avoid someone > thinking that it is a bug at some later stage. The text in the commit message > above is suitable. >
Good suggestion! Will add it :) > John. > --
