On 4/12/2023 5:26 PM, Ronak Doshi wrote:
> This patch enhances vmxnet3 to suuport capability registers which
s/suuport/support/
> allows it to enable features selectively. The DCR register tracks
> the capabilities vmxnet3 device supports. The PTCR register states
> the capabilities that the passthrough device supports.
>
> With the help of these registers, vmxnet3 can enable only those
> features which the passthrough device supoprts. This allows
s/supoprts/supports/
> smooth trasition to Uniform-Passthrough (UPT) mode if the virtual
s/trasition/transition/
> nic requests it. If PTCR register returns nothing or error it means
s/nic/NIC/
> UPT is not being requested and vnic will continue in emulation mode.
>
> Signed-off-by: Ronak Doshi <dos...@vmware.com>
> Acked-by: Jochen Behrens <jbehr...@vmware.com>
<...>
> +static int
> +eth_vmxnet3_setup_capabilities(struct vmxnet3_hw *hw,
> + struct rte_eth_dev *eth_dev)
> +{
> + uint32_t dcr, ptcr, value;
> + struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
> +
> + VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD,
> + VMXNET3_CMD_GET_MAX_CAPABILITIES);
> + value = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD);
> + hw->max_capabilities[0] = value;
> + dcr = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_DCR);
> + hw->DCR_capabilities[0] = dcr;
> + hw->used_DCR_capabilities[0] = 0;
> + ptcr = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_PTCR);
> + hw->PTCR_capabilities[0] = ptcr;
> + hw->used_PTCR_capabilities[0] = 0;
> +
> + if (hw->uptv2_enabled && !(ptcr & (1 << VMXNET3_DCR_ERROR))) {
> + PMD_DRV_LOG(NOTICE, "UPTv2 enabled");
> + hw->used_PTCR_capabilities[0] = ptcr;
> + } else {
> + /* Use all DCR capabilities, but disable large bar */
> + hw->used_DCR_capabilities[0] = dcr &
> + (~(1UL << VMXNET3_CAP_LARGE_BAR));
> + PMD_DRV_LOG(NOTICE, "UPTv2 disabled");
> + }
> + if (hw->DCR_capabilities[0] & (1UL << VMXNET3_CAP_OOORX_COMP) &&
> + hw->PTCR_capabilities[0] & (1UL << VMXNET3_CAP_OOORX_COMP)) {
> + if (hw->uptv2_enabled) {
> + hw->used_PTCR_capabilities[0] |=
> + (1UL << VMXNET3_CAP_OOORX_COMP);
> + }
> + }
> + if (hw->used_PTCR_capabilities[0]) {
> + VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_DCR,
> + hw->used_PTCR_capabilities[0]);
> + } else if (hw->used_DCR_capabilities[0]) {
> + VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_DCR,
> + hw->used_DCR_capabilities[0]);
> + }
> + VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_DCR0_REG);
> + dcr = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD);
> + hw->used_DCR_capabilities[0] = dcr;
> + PMD_DRV_LOG(NOTICE, "Dev "PCI_PRI_FMT", vmxnet3 v%d, UPT enabled: %s, "
Checkpatch complains about syntax:
HECK:CONCATENATED_STRING: Concatenated strings should use spaces between
elements
#200: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:346:
+ PMD_DRV_LOG(NOTICE, "Dev "PCI_PRI_FMT", vmxnet3 v%d, UPT enabled: %s, "
> + "DCR0=0x%08x, used DCR=0x%08x, "
> + "PTCR=0x%08x, used PTCR=0x%08x",
> + pci_dev->addr.domain, pci_dev->addr.bus,
> + pci_dev->addr.devid, pci_dev->addr.function, hw->version,
> + hw->uptv2_enabled ? "true" : "false",
> + hw->DCR_capabilities[0], hw->used_DCR_capabilities[0],
> + hw->PTCR_capabilities[0], hw->used_PTCR_capabilities[0]);
This log level is NOTICE, making it visible by default. And this
function always called when vesion >= 7.
Are you sure to make log this verbose? Or can it be DEBUG level?
<...>
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -1606,6 +1606,8 @@ struct rte_eth_conf {
> #define RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP RTE_BIT64(3)
> /** Device supports keeping shared flow objects across restart. */
> #define RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP RTE_BIT64(4)
> +/**< (vmxnet3) Device supports smart NIC pass through queues */
> +#define RTE_ETH_DEV_CAPA_PASS_THRU RTE_BIT64(5)
'dev_info->dev_capa' is for generic device capabilities, we can't have
device specific capability here.
Can you please describe why it is required to expose this capability to
user, what user should do with this information?
