> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Tuesday, April 25, 2023 12:24 AM
> To: Zhang, Qi Z <qi.z.zh...@intel.com>
> Cc: Xing, Beilei <beilei.x...@intel.com>; dev@dpdk.org
> Subject: Re: [PATCH] common/idpf: remove unnecessary compile option
> 
> On Mon, 24 Apr 2023 18:47:00 -0400
> Qi Zhang <qi.z.zh...@intel.com> wrote:
> 
> > Remove compile option "__KERNEL" which should not be considered in
> > DPDK. Also only #include <rte_xxx> in idpf_osdep.h.
> >
> > Signed-off-by: Qi Zhang <qi.z.zh...@intel.com>
> 
> This will cause some warnings in DPDK build depending on compiler version
> and flags.  You need to leave the fallthrough comment or use one of the
> other fallthrough annotations.

no intention of removing that comment, as it serves to assist the reader. 
It's good to learn that it has also helped to resolve the compiler warning - 
thank you for bringing this to my attention.

Reply via email to