From: Beilei Xing <beilei.x...@intel.com>

Initialize required capability in PMD, and refine
idpf_vc_caps_get function. Then different PMDs can
require different capability.

Signed-off-by: Beilei Xing <beilei.x...@intel.com>
---
v5 changes:
 - No need to move check_pf_reset_done and mbx_init from common module.
V4 changes:
 - No need to require PTP CAP for CPFL. 
V3 changes:
 - refine capability get.
 
 drivers/common/idpf/idpf_common_virtchnl.c | 45 ++--------------------
 drivers/net/cpfl/cpfl_ethdev.c             | 40 +++++++++++++++++++
 drivers/net/idpf/idpf_ethdev.c             | 40 +++++++++++++++++++
 3 files changed, 83 insertions(+), 42 deletions(-)

diff --git a/drivers/common/idpf/idpf_common_virtchnl.c 
b/drivers/common/idpf/idpf_common_virtchnl.c
index 9ee7259539..a4e129062e 100644
--- a/drivers/common/idpf/idpf_common_virtchnl.c
+++ b/drivers/common/idpf/idpf_common_virtchnl.c
@@ -278,51 +278,12 @@ idpf_vc_api_version_check(struct idpf_adapter *adapter)
 int
 idpf_vc_caps_get(struct idpf_adapter *adapter)
 {
-       struct virtchnl2_get_capabilities caps_msg;
        struct idpf_cmd_info args;
        int err;
 
-       memset(&caps_msg, 0, sizeof(struct virtchnl2_get_capabilities));
-
-       caps_msg.csum_caps =
-               VIRTCHNL2_CAP_TX_CSUM_L3_IPV4          |
-               VIRTCHNL2_CAP_TX_CSUM_L4_IPV4_TCP      |
-               VIRTCHNL2_CAP_TX_CSUM_L4_IPV4_UDP      |
-               VIRTCHNL2_CAP_TX_CSUM_L4_IPV4_SCTP     |
-               VIRTCHNL2_CAP_TX_CSUM_L4_IPV6_TCP      |
-               VIRTCHNL2_CAP_TX_CSUM_L4_IPV6_UDP      |
-               VIRTCHNL2_CAP_TX_CSUM_L4_IPV6_SCTP     |
-               VIRTCHNL2_CAP_TX_CSUM_GENERIC          |
-               VIRTCHNL2_CAP_RX_CSUM_L3_IPV4          |
-               VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_TCP      |
-               VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_UDP      |
-               VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_SCTP     |
-               VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_TCP      |
-               VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_UDP      |
-               VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_SCTP     |
-               VIRTCHNL2_CAP_RX_CSUM_GENERIC;
-
-       caps_msg.rss_caps =
-               VIRTCHNL2_CAP_RSS_IPV4_TCP             |
-               VIRTCHNL2_CAP_RSS_IPV4_UDP             |
-               VIRTCHNL2_CAP_RSS_IPV4_SCTP            |
-               VIRTCHNL2_CAP_RSS_IPV4_OTHER           |
-               VIRTCHNL2_CAP_RSS_IPV6_TCP             |
-               VIRTCHNL2_CAP_RSS_IPV6_UDP             |
-               VIRTCHNL2_CAP_RSS_IPV6_SCTP            |
-               VIRTCHNL2_CAP_RSS_IPV6_OTHER           |
-               VIRTCHNL2_CAP_RSS_IPV4_AH              |
-               VIRTCHNL2_CAP_RSS_IPV4_ESP             |
-               VIRTCHNL2_CAP_RSS_IPV4_AH_ESP          |
-               VIRTCHNL2_CAP_RSS_IPV6_AH              |
-               VIRTCHNL2_CAP_RSS_IPV6_ESP             |
-               VIRTCHNL2_CAP_RSS_IPV6_AH_ESP;
-
-       caps_msg.other_caps = VIRTCHNL2_CAP_WB_ON_ITR;
-
        args.ops = VIRTCHNL2_OP_GET_CAPS;
-       args.in_args = (uint8_t *)&caps_msg;
-       args.in_args_size = sizeof(caps_msg);
+       args.in_args = (uint8_t *)&adapter->caps;
+       args.in_args_size = sizeof(struct virtchnl2_get_capabilities);
        args.out_buffer = adapter->mbx_resp;
        args.out_size = IDPF_DFLT_MBX_BUF_SIZE;
 
@@ -333,7 +294,7 @@ idpf_vc_caps_get(struct idpf_adapter *adapter)
                return err;
        }
 
-       rte_memcpy(&adapter->caps, args.out_buffer, sizeof(caps_msg));
+       rte_memcpy(&adapter->caps, args.out_buffer, sizeof(struct 
virtchnl2_get_capabilities));
 
        return 0;
 }
diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c
index ede730fd50..517ae15f4c 100644
--- a/drivers/net/cpfl/cpfl_ethdev.c
+++ b/drivers/net/cpfl/cpfl_ethdev.c
@@ -1165,6 +1165,44 @@ cpfl_dev_alarm_handler(void *param)
        rte_eal_alarm_set(CPFL_ALARM_INTERVAL, cpfl_dev_alarm_handler, adapter);
 }
 
+static struct virtchnl2_get_capabilities req_caps = {
+       .csum_caps =
+       VIRTCHNL2_CAP_TX_CSUM_L3_IPV4          |
+       VIRTCHNL2_CAP_TX_CSUM_L4_IPV4_TCP      |
+       VIRTCHNL2_CAP_TX_CSUM_L4_IPV4_UDP      |
+       VIRTCHNL2_CAP_TX_CSUM_L4_IPV4_SCTP     |
+       VIRTCHNL2_CAP_TX_CSUM_L4_IPV6_TCP      |
+       VIRTCHNL2_CAP_TX_CSUM_L4_IPV6_UDP      |
+       VIRTCHNL2_CAP_TX_CSUM_L4_IPV6_SCTP     |
+       VIRTCHNL2_CAP_TX_CSUM_GENERIC          |
+       VIRTCHNL2_CAP_RX_CSUM_L3_IPV4          |
+       VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_TCP      |
+       VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_UDP      |
+       VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_SCTP     |
+       VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_TCP      |
+       VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_UDP      |
+       VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_SCTP     |
+       VIRTCHNL2_CAP_RX_CSUM_GENERIC,
+
+       .rss_caps =
+       VIRTCHNL2_CAP_RSS_IPV4_TCP             |
+       VIRTCHNL2_CAP_RSS_IPV4_UDP             |
+       VIRTCHNL2_CAP_RSS_IPV4_SCTP            |
+       VIRTCHNL2_CAP_RSS_IPV4_OTHER           |
+       VIRTCHNL2_CAP_RSS_IPV6_TCP             |
+       VIRTCHNL2_CAP_RSS_IPV6_UDP             |
+       VIRTCHNL2_CAP_RSS_IPV6_SCTP            |
+       VIRTCHNL2_CAP_RSS_IPV6_OTHER           |
+       VIRTCHNL2_CAP_RSS_IPV4_AH              |
+       VIRTCHNL2_CAP_RSS_IPV4_ESP             |
+       VIRTCHNL2_CAP_RSS_IPV4_AH_ESP          |
+       VIRTCHNL2_CAP_RSS_IPV6_AH              |
+       VIRTCHNL2_CAP_RSS_IPV6_ESP             |
+       VIRTCHNL2_CAP_RSS_IPV6_AH_ESP,
+
+       .other_caps = VIRTCHNL2_CAP_WB_ON_ITR
+};
+
 static int
 cpfl_adapter_ext_init(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext 
*adapter)
 {
@@ -1181,6 +1219,8 @@ cpfl_adapter_ext_init(struct rte_pci_device *pci_dev, 
struct cpfl_adapter_ext *a
 
        strncpy(adapter->name, pci_dev->device.name, PCI_PRI_STR_SIZE);
 
+       rte_memcpy(&base->caps, &req_caps, sizeof(struct 
virtchnl2_get_capabilities));
+
        ret = idpf_adapter_init(base);
        if (ret != 0) {
                PMD_INIT_LOG(ERR, "Failed to init adapter");
diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c
index e02ec2ec5a..899fdf8b29 100644
--- a/drivers/net/idpf/idpf_ethdev.c
+++ b/drivers/net/idpf/idpf_ethdev.c
@@ -1128,6 +1128,44 @@ idpf_dev_alarm_handler(void *param)
        rte_eal_alarm_set(IDPF_ALARM_INTERVAL, idpf_dev_alarm_handler, adapter);
 }
 
+static struct virtchnl2_get_capabilities req_caps = {
+       .csum_caps =
+       VIRTCHNL2_CAP_TX_CSUM_L3_IPV4          |
+       VIRTCHNL2_CAP_TX_CSUM_L4_IPV4_TCP      |
+       VIRTCHNL2_CAP_TX_CSUM_L4_IPV4_UDP      |
+       VIRTCHNL2_CAP_TX_CSUM_L4_IPV4_SCTP     |
+       VIRTCHNL2_CAP_TX_CSUM_L4_IPV6_TCP      |
+       VIRTCHNL2_CAP_TX_CSUM_L4_IPV6_UDP      |
+       VIRTCHNL2_CAP_TX_CSUM_L4_IPV6_SCTP     |
+       VIRTCHNL2_CAP_TX_CSUM_GENERIC          |
+       VIRTCHNL2_CAP_RX_CSUM_L3_IPV4          |
+       VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_TCP      |
+       VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_UDP      |
+       VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_SCTP     |
+       VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_TCP      |
+       VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_UDP      |
+       VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_SCTP     |
+       VIRTCHNL2_CAP_RX_CSUM_GENERIC,
+
+       .rss_caps =
+       VIRTCHNL2_CAP_RSS_IPV4_TCP             |
+       VIRTCHNL2_CAP_RSS_IPV4_UDP             |
+       VIRTCHNL2_CAP_RSS_IPV4_SCTP            |
+       VIRTCHNL2_CAP_RSS_IPV4_OTHER           |
+       VIRTCHNL2_CAP_RSS_IPV6_TCP             |
+       VIRTCHNL2_CAP_RSS_IPV6_UDP             |
+       VIRTCHNL2_CAP_RSS_IPV6_SCTP            |
+       VIRTCHNL2_CAP_RSS_IPV6_OTHER           |
+       VIRTCHNL2_CAP_RSS_IPV4_AH              |
+       VIRTCHNL2_CAP_RSS_IPV4_ESP             |
+       VIRTCHNL2_CAP_RSS_IPV4_AH_ESP          |
+       VIRTCHNL2_CAP_RSS_IPV6_AH              |
+       VIRTCHNL2_CAP_RSS_IPV6_ESP             |
+       VIRTCHNL2_CAP_RSS_IPV6_AH_ESP,
+
+       .other_caps = VIRTCHNL2_CAP_WB_ON_ITR
+};
+
 static int
 idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext 
*adapter)
 {
@@ -1144,6 +1182,8 @@ idpf_adapter_ext_init(struct rte_pci_device *pci_dev, 
struct idpf_adapter_ext *a
 
        strncpy(adapter->name, pci_dev->device.name, PCI_PRI_STR_SIZE);
 
+       rte_memcpy(&base->caps, &req_caps, sizeof(struct 
virtchnl2_get_capabilities));
+
        ret = idpf_adapter_init(base);
        if (ret != 0) {
                PMD_INIT_LOG(ERR, "Failed to init adapter");
-- 
2.26.2

Reply via email to