> -----Original Message----- > From: Luca Boccassi <luca.bocca...@gmail.com> > Sent: Wednesday, April 19, 2023 5:30 PM > To: Kevin Traynor <ktray...@redhat.com> > Cc: Ali Alnubani <alia...@nvidia.com>; David Marchand > <david.march...@redhat.com>; sta...@dpdk.org; dev@dpdk.org; > Abhishek Marathe <abhishek.mara...@microsoft.com>; > benjamin.wal...@intel.com; David Christensen <d...@linux.vnet.ibm.com>; > Hemant Agrawal <hemant.agra...@nxp.com>; Ian Stokes > <ian.sto...@intel.com>; Jerin Jacob <jer...@marvell.com>; John McNamara > <john.mcnam...@intel.com>; Ju-Hyoung Lee <juh...@microsoft.com>; Pei > Zhang <pezh...@redhat.com>; qian.q...@intel.com; Raslan Darawsheh > <rasl...@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL) > <tho...@monjalon.net>; Yanghang Liu <yangh...@redhat.com>; > yuan.p...@intel.com; zhaoyan.c...@intel.com > Subject: Re: 20.11.8 patches review and test > > On Wed, 19 Apr 2023 at 15:26, Kevin Traynor <ktray...@redhat.com> wrote: > > > > On 19/04/2023 15:23, Ali Alnubani wrote: > > >> -----Original Message----- > > >> From: Luca Boccassi <luca.bocca...@gmail.com> > > >> Sent: Wednesday, April 19, 2023 5:15 PM > > >> To: David Marchand <david.march...@redhat.com> > > >> Cc: Ali Alnubani <alia...@nvidia.com>; sta...@dpdk.org; > dev@dpdk.org; > > >> Abhishek Marathe <abhishek.mara...@microsoft.com>; > > >> benjamin.wal...@intel.com; David Christensen > <d...@linux.vnet.ibm.com>; > > >> Hemant Agrawal <hemant.agra...@nxp.com>; Ian Stokes > > >> <ian.sto...@intel.com>; Jerin Jacob <jer...@marvell.com>; John > McNamara > > >> <john.mcnam...@intel.com>; Ju-Hyoung Lee > <juh...@microsoft.com>; > > >> Kevin Traynor <ktray...@redhat.com>; Pei Zhang > <pezh...@redhat.com>; > > >> qian.q...@intel.com; Raslan Darawsheh <rasl...@nvidia.com>; NBU- > > >> Contact-Thomas Monjalon (EXTERNAL) <tho...@monjalon.net>; > Yanghang > > >> Liu <yangh...@redhat.com>; yuan.p...@intel.com; > > >> zhaoyan.c...@intel.com > > >> Subject: Re: 20.11.8 patches review and test > > >> > > >> On Wed, 19 Apr 2023 at 14:25, David Marchand > > >> <david.march...@redhat.com> wrote: > > >>> > > >>> On Wed, Apr 19, 2023 at 3:14 PM Ali Alnubani <alia...@nvidia.com> > wrote: > > >>>>> > > >>>>> I don't think this function prototype is really different in the 20.11 > > >>>>> stable branch (putting the __rte_internal tag aside). > > >>>>> Can you trigger this issue on the main branch? > > >>>>> > > >>>> > > >>>> The main branch doesn't reproduce on the same environment. > > >>> > > >>> Ok, same for me, I reproduced for 20.11 but not for main. > > >>> > > >>> > > >>> I think I have the reason. > > >>> We filter headers to be processed by doxygen via a name filter: > > >>> > > >>> FILE_PATTERNS = rte_*.h \ > > >>> > > >>> But this rte_cryptodev_pmd.h driver header has been renamed as > > >>> cryptodev_pmd.h in 21.11. > > >>> So the issue you reported only affects 20.11. > > >> > > >> I can reproduce in debian testing, after backporting the mentioned > > >> commit from main it seems fine, can you confirm as well that it works > > >> in fedora? > > >> > > >> https://github.com/bluca/dpdk- > > >> stable/commit/77f65b61f955fd817b3791049dda3032c459ac59 > > > > > > Now I see a different error: > > > > > > [2/4] Generating doc/api/doxygen with a custom command > > > FAILED: doc/api/html > > > /tmp/dpdk/doc/api/generate_doxygen.sh doc/api/doxy-api.conf > doc/api/html /tmp/dpdk/doc/api/doxy-html-custom.sh > > > /tmp/dpdk/lib/librte_vhost/rte_vhost_async.h:49: error: > rte_vhost_async_channel_ops::transfer_data has @param documentation > sections but no arguments (warning treated as error, aborting now) > > > > See > > https://git.dpdk.org/dpdk- > stable/commit/?h=21.11&id=adeaf361f0a5bb3992756fd4e727dd11ecca0943 > > Thanks, any more errors with > https://github.com/bluca/dpdk- > stable/commit/b75ebf643de0204d0092a56fbec63f0bcd10e89f > ?
Build on Fedora with Doxygen 1.9.5 now passes with both patches: https://github.com/bluca/dpdk-stable/commit/77f65b61f955fd817b3791049dda3032c459ac59.patch https://github.com/bluca/dpdk-stable/commit/b75ebf643de0204d0092a56fbec63f0bcd10e89f.patch Thanks!
