Hi Qian, > -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qian Xu > Sent: Tuesday, November 17, 2015 12:09 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v4] doc: add nic performance guide on linux gsg > > Add a new guide doc as part of the Linux Getting Started Guide. > > The document is a step-by-step guide on how to get high performance with > DPDK on an Intel platform. > > It is designed for users who are not familiar with DPDK but would like to > get the best performance with NICs. > > Signed-off-by: Qian Xu <qian.q.xu at intel.com> > > Changes in v4: > * Update some naming and wordings according to Thomas's comments.
I think the "Changes" should be separated from the commit message by a single line with ---. Thomas is that correct? > +Network Interface Card Requirements > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ... > + > +Care should be take with NUMA. > +If you are using 2 or more ports from different NICs, it is best to > ensure that these NICs on the same CPU socket. Minor typo: NICs are on the same CPU socket. > +Example of getting best performance for an Intel NIC > +---------------------------------------------------- > + > .. > +2. Connect the ports to the traffic generator. To check the best > performance ,we suggest to use high speed traffic generator, such as > hardware traffic generator IXIA or Spirent. In the sample, we are using > IXIA. Thomas suggested previously to omit brand names like IXIA or Spirent. Something generic like the following would be better: 2. Connect the ports to the traffic generator. For high speed testing it is best to use a hardware traffic generator. This will need to change in the image as well. > + > +3. Check the PCI devices numa node (socket id) and get the cores number > on the exact socket id. > + In this case, ``82:00.0`` and ``85:00.0`` are both in socket 1, and > the cores on socket 1 in the referenced platform > + are 18-35 and 54-71. > + Note: Don't use one 2 logical cores on the same core (e.g core18 has 2 Minor typo from last time: Don't use 2 logical cores .. John. --