On 3/28/2023 10:35 AM, Guo, Junfeng wrote: > > >> -----Original Message----- >> From: Ferruh Yigit <ferruh.yi...@amd.com> >> Sent: Tuesday, March 28, 2023 16:57 >> To: Guo, Junfeng <junfeng....@intel.com>; Zhang, Qi Z >> <qi.z.zh...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Xing, >> Beilei <beilei.x...@intel.com> >> Cc: dev@dpdk.org; Rushil Gupta <rush...@google.com>; Joshua >> Washington <joshw...@google.com>; Jeroen de Borst >> <jeroe...@google.com> >> Subject: Re: [PATCH 2/2] net/gve: update copyright holders >> >> On 3/28/2023 3:08 AM, Junfeng Guo wrote: >>> Add Google LLC as one of the copyright holders for GVE. >>> >>> Signed-off-by: Rushil Gupta <rush...@google.com> >>> Signed-off-by: Joshua Washington <joshw...@google.com> >>> Signed-off-by: Junfeng Guo <junfeng....@intel.com> >>> Signed-off-by: Jeroen de Borst <jeroe...@google.com> >>> --- >>> drivers/net/gve/gve_ethdev.c | 32 >> ++++++++++++++++++++++++++++++-- >>> drivers/net/gve/gve_ethdev.h | 32 >> ++++++++++++++++++++++++++++++-- >>> drivers/net/gve/gve_logs.h | 32 ++++++++++++++++++++++++++++++- >> - >>> drivers/net/gve/gve_rx.c | 32 ++++++++++++++++++++++++++++++-- >>> drivers/net/gve/gve_tx.c | 32 ++++++++++++++++++++++++++++++-- >>> drivers/net/gve/meson.build | 31 >> ++++++++++++++++++++++++++++++- >>> 6 files changed, 180 insertions(+), 11 deletions(-) >>> >>> diff --git a/drivers/net/gve/gve_ethdev.c >> b/drivers/net/gve/gve_ethdev.c >>> index cf28a4a3b7..1b8f0fde8f 100644 >>> --- a/drivers/net/gve/gve_ethdev.c >>> +++ b/drivers/net/gve/gve_ethdev.c >>> @@ -1,5 +1,33 @@ >>> -/* SPDX-License-Identifier: BSD-3-Clause >>> - * Copyright(C) 2022 Intel Corporation >>> +/* >>> + * SPDX-License-Identifier: BSD-3-Clause >>> + * >>> + * Copyright (c) 2022-2023 Google LLC >>> + * Copyright (c) 2022-2023 Intel Corporation >>> + * >>> + * Redistribution and use in source and binary forms, with or without >> modification, >>> + * are permitted provided that the following conditions are met: >>> + * >>> + * 1. Redistributions of source code must retain the above copyright >> notice, this >>> + * list of conditions and the following disclaimer. >>> + * >>> + * 2. Redistributions in binary form must reproduce the above >> copyright notice, >>> + * this list of conditions and the following disclaimer in the >> documentation >>> + * and/or other materials provided with the distribution. >>> + * >>> + * 3. Neither the name of the copyright holder nor the names of its >> contributors >>> + * may be used to endorse or promote products derived from this >> software without >>> + * specific prior written permission. >>> + * >>> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND >> CONTRIBUTORS "AS IS" AND >>> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT >> LIMITED TO, THE IMPLIED >>> + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A >> PARTICULAR PURPOSE ARE >>> + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR >> CONTRIBUTORS BE LIABLE FOR >>> + * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR >> CONSEQUENTIAL DAMAGES >>> + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF >> SUBSTITUTE GOODS OR SERVICES; >>> + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) >> HOWEVER CAUSED AND ON >>> + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT >> LIABILITY, OR TORT >>> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY >> OUT OF THE USE OF THIS >>> + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH >> DAMAGE. >>> */ >> >> Can you please separate the patches that updates license and copyright? > > Sure. > > The background is that, in the past (DPDK 22.11) we didn't get the approval > of license from Google, thus chose the MIT License for the base code, and > BSD-3 License for GVE common code (without the files in /base folder). > We also left the copyright holder of base code just to Google Inc, and made > Intel as the copyright holder of GVE common code (without /base folder). > > Today we are working together for GVE dev and maintaining. And we got > the approval of BSD-3 License from Google for the base code. > Thus we dicided to 1) switch the License of GVE base code from MIT to BSD-3; > 2) add Google LLC as one of the copyright holders for GVE common code. >
+1 to switch the DPDK common BSD-3 license, instead of having an exception for the driver, it simplifies things. Thank you for following this up.
