> On 2/16/2023 8:32 AM, Chaoyong He wrote: > > From: Long Wu <long...@corigine.com> > > > > If bonding port is mode4 with disabling dedicated queue and there are > > no other packets, forward loop will not call port's TX function and > > bonding port will not send LACP packets. > > > > Add sending LACP packets periodically in forward loop to avoid LACP > > negotiation failed. > > > > Signed-off-by: Long Wu <long...@corigine.com> > > Reviewed-by: Niklas Söderlund <niklas.soderl...@corigine.com> > > Reviewed-by: Chaoyong He <chaoyong...@corigine.com> > > --- > > app/test-pmd/config.c | 23 ++++++++++++++ > > app/test-pmd/parameters.c | 10 +++++++ > > app/test-pmd/testpmd.c | 43 ++++++++++++++++++++++++++- > > app/test-pmd/testpmd.h | 9 ++++++ > > doc/guides/testpmd_app_ug/run_app.rst | 4 +++ > > 5 files changed, 88 insertions(+), 1 deletion(-) > > Is it possible to have this support in > 'drivers/net/bonding/bonding_testpmd.c', to not add PMD specific ifdefs to > the generic testpmd code. Like having a bonding specific command etc.. > > btw, I didn't check the details, just a high level question.
The logic in this patch depends on the initial and forward process of testpmd app. I think the file 'drivers/net/bonding/bonding_testpmd.c' aims to configure the bonding port, but what we really want to do is configure testpmd app. So, I think it is not very good to move it. Long also have a try, and seems it's impossible to avoid modify the logic in 'testpmd.c'.
