On 2/19/2023 12:31 AM, Levend Sayar wrote: > Google Virtual NIC PMD is enriched with rx/tx queue statistics info. > > Signed-off-by: Levend Sayar <levendsa...@gmail.com> > --- > drivers/net/gve/gve_ethdev.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c > index fef2458a16..2a6cb11da3 100644 > --- a/drivers/net/gve/gve_ethdev.c > +++ b/drivers/net/gve/gve_ethdev.c > @@ -213,6 +213,7 @@ gve_dev_start(struct rte_eth_dev *dev) > } > } > > + dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS; > dev->data->dev_started = 1; > gve_link_update(dev, 0); > > @@ -331,6 +332,9 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct > rte_eth_stats *stats) > stats->opackets += txq->packets; > stats->obytes += txq->bytes; > stats->oerrors += txq->errors; > + > + stats->q_opackets[i] = txq->packets; > + stats->q_obytes[i] = txq->bytes; > } > > for (i = 0; i < dev->data->nb_rx_queues; i++) { > @@ -342,6 +346,10 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct > rte_eth_stats *stats) > stats->ibytes += rxq->bytes; > stats->ierrors += rxq->errors; > stats->rx_nombuf += rxq->no_mbufs; > + > + stats->q_ipackets[i] = rxq->packets; > + stats->q_ibytes[i] = rxq->bytes; > + stats->q_errors[i] = rxq->errors; > } > > return 0;
nack, as explained in other thread [1], we need to implement xstats in driver without relying on 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. [1] https://inbox.dpdk.org/dev/0123d577-39f5-7213-07b3-04ef3918e...@amd.com/T/#u