Hi Ferruh, Thanks for your comments. Yes, you’re right. After I sent v2 of my patches, I got an error mail saying unable to merge. New patches from Junfeng pushed to the repo for net/gve. Anyway I have done requested on patchwork and superseded these v2 patch set. Sorry for the inconvenience.
Best, Levend > On 17 Feb 2023, at 15:43, Ferruh Yigit <ferruh.yi...@amd.com> wrote: > > On 2/16/2023 6:10 PM, Levend Sayar wrote: >> Google Virtual NIC is not doing IPv4 checksummimg. >> Removed that capability from PMD. >> >> Signed-off-by: Levend Sayar <levendsa...@gmail.com> >> --- >> drivers/net/gve/gve_ethdev.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c >> index 97781f0ed3..e357f16e16 100644 >> --- a/drivers/net/gve/gve_ethdev.c >> +++ b/drivers/net/gve/gve_ethdev.c >> @@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct >> rte_eth_dev_info *dev_info) >> dev_info->rx_offload_capa = 0; >> dev_info->tx_offload_capa = >> RTE_ETH_TX_OFFLOAD_MULTI_SEGS | >> - RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | >> RTE_ETH_TX_OFFLOAD_UDP_CKSUM | >> RTE_ETH_TX_OFFLOAD_TCP_CKSUM | >> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | > > Hi Levend, > > > there are multiple version of same patch, it is confusing for reviewers > and maintainers. > > Can you please: > > - User versions tag, and keep increasing it. Like this one has v2, which > is good, but next one sent after this doesn't have any version tag. > > - Use git send-email '--in-reply-to' parameter to keep all versions in > same email thread. More details on documentation: > https://doc.dpdk.org/guides/contributing/patches.html#sending-patches > > - Clean patchwork after a new version sent by marking old version > appropriately (most of times as 'superseded') > https://patches.dpdk.org/project/dpdk/list/?submitter=1813 > > > Thanks, > ferruh
