On 2/6/2023 9:19 PM, David Marchand wrote:
If allocating the ports[] array fails, a crash will occur when shutting
down testpmd since ethdev emits RTE_ETH_EVENT_DESTROY events.
Move init_port() before registering ethdev event handler.
Looks ok to me. Avoids seg_fault, due to Null pointer access.
Fixes: 85c6571c9103 ("app/testpmd: reset port status on close notification")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand <david.march...@redhat.com>
Acked-by: Aman Singh <aman.deep.si...@intel.com>
---
app/test-pmd/testpmd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index e366f81a0f..de3017fd62 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -4385,6 +4385,9 @@ main(int argc, char** argv)
rte_exit(EXIT_FAILURE, "Cannot init EAL: %s\n",
rte_strerror(rte_errno));
+ /* allocate port structures, and init them */
+ init_port();
+
ret = register_eth_event_callback();
if (ret != 0)
rte_exit(EXIT_FAILURE, "Cannot register for ethdev events");
@@ -4403,9 +4406,6 @@ main(int argc, char** argv)
if (nb_ports == 0)
TESTPMD_LOG(WARNING, "No probed ethernet devices\n");
- /* allocate port structures, and init them */
- init_port();
-
set_def_fwd_config();
if (nb_lcores == 0)
rte_exit(EXIT_FAILURE, "No cores defined for forwarding\n"
