On Thu, Feb 9, 2023 at 2:30 PM Ankur Dwivedi <adwiv...@marvell.com> wrote: > > The file rte_mempool_trace.h contains tracepoints which are internal to the > mempool library. This file is renamed to mempool_trace.h, and is made an > internal header. The tracepoints in this file are removed from the
This patch also exports this new internal header which looks wrong to me. See below. > experimental section in version.map file. > > Signed-off-by: Ankur Dwivedi <adwiv...@marvell.com> > diff --git a/lib/mempool/meson.build b/lib/mempool/meson.build > index b8aaa00694..29ae6d21e5 100644 > --- a/lib/mempool/meson.build > +++ b/lib/mempool/meson.build > @@ -17,7 +17,9 @@ sources = files( > ) > headers = files( > 'rte_mempool.h', > - 'rte_mempool_trace.h', > 'rte_mempool_trace_fp.h', > ) > +driver_sdk_headers += files( > + 'mempool_trace.h', > +) driver_sdk_headers is for exporting driver headers. I am not sure why you added this, can you elaborate? Checking with who includes this header in the whole tree: $ git grep include..mempool_trace lib/mempool/mempool_trace_points.c:#include "mempool_trace.h" lib/mempool/rte_mempool.c:#include "mempool_trace.h" lib/mempool/rte_mempool_ops.c:#include "mempool_trace.h" I see no external (from the mempool library pov) user of this header => no export needed. I did not check the rest of the series, but the same argument is likely to apply. Thanks. -- David Marchand
