On Fri, 03 Feb 2023 21:49:02 +0100 Thomas Monjalon <tho...@monjalon.net> wrote:
> > > > > Good catch. > > > > > By the way, we should remove unused RTE_LOGTYPE_*. > > > > > > > > Yes, for 23.11 would like to work down the list. > > > > > > Do we need to wait 23.11? > > > It is not an ABI breakage. > > > And most of these defines are already unused. > > > > Turning them into deprecated would be API breakage though > > API breakage is not forbidden. > For the internal ones it would be ok, but what about the RTE_LOGTYPE_USER1 etc. These need to go through the regular deprecation process. The problem is that if the the types are not registered (see eal_common_log.c) they might get reused.