RE: [PATCH v3 3/6] common/idpf: support single q scatter RX datapath

[Liu, Mingxia]

> -----Original Message-----
> From: Wu, Jingjing <jingjing...@intel.com>
> Sent: Thursday, February 2, 2023 11:46 AM
> To: Liu, Mingxia <mingxia....@intel.com>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.x...@intel.com>; Wu, Wenjun1
> <wenjun1...@intel.com>
> Subject: RE: [PATCH v3 3/6] common/idpf: support single q scatter RX
> datapath
> 
> >
> > +uint16_t
> > +idpf_singleq_recv_scatter_pkts(void *rx_queue, struct rte_mbuf
> **rx_pkts,
> > +                          uint16_t nb_pkts)
> > +{
> > +   struct idpf_rx_queue *rxq = rx_queue;
> > +   volatile union virtchnl2_rx_desc *rx_ring = rxq->rx_ring;
> > +   volatile union virtchnl2_rx_desc *rxdp;
> > +   union virtchnl2_rx_desc rxd;
> > +   struct idpf_adapter *ad;
> > +   struct rte_mbuf *first_seg = rxq->pkt_first_seg;
> > +   struct rte_mbuf *last_seg = rxq->pkt_last_seg;
> > +   struct rte_mbuf *rxm;
> > +   struct rte_mbuf *nmb;
> > +   struct rte_eth_dev *dev;
> > +   const uint32_t *ptype_tbl = rxq->adapter->ptype_tbl;
> > +   uint16_t nb_hold = 0, nb_rx = 0;
> According to the coding style, only the last variable on a line should be
> initialized.
> 
[Liu, Mingxia] Ok, thank, I'll check if the same issue exist otherwhere.

> > +   uint16_t rx_id = rxq->rx_tail;
> > +   uint16_t rx_packet_len;
> > +   uint16_t rx_status0;
> > +   uint64_t pkt_flags;
> > +   uint64_t dma_addr;
> > +   uint64_t ts_ns;
> > +