Hi, Kaiwen
The code looks good to me.
Can you ask someone to test this behavior and add a tested-by?
Qiming
> -----Original Message-----
> From: Deng, KaiwenX <kaiwenx.d...@intel.com>
> Sent: Saturday, January 28, 2023 3:15 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Zhou, YidingX <yidingx.z...@intel.com>; Deng,
> KaiwenX <kaiwenx.d...@intel.com>; Yang, Qiming
> <qiming.y...@intel.com>; Wu, Wenjun1 <wenjun1...@intel.com>; Zhao1,
> Wei <wei.zh...@intel.com>; Xing, Beilei <beilei.x...@intel.com>; Lu,
> Wenzhuo <wenzhuo...@intel.com>; Dai, Wei <wei....@intel.com>
> Subject: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
>
> Add IPv6 addr mask and L4 mask support for rte_flow APIs.
>
> IPv6 flow rules do not take effect in ixgbe when set
> IPv6 addr mask and L4 mask to default value as 0xFF.
>
> Set IPv6 addr mask and L4 mask as 0 to enable fields can fix this issue.
>
> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.d...@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_flow.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> index 110ff34fcc..d2ba87df27 100644
> --- a/drivers/net/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> @@ -1645,6 +1645,10 @@ ixgbe_parse_fdir_filter_normal(struct
> rte_eth_dev *dev,
> memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask));
> rule->mask.vlan_tci_mask = 0;
> rule->mask.flex_bytes_mask = 0;
> + rule->mask.dst_port_mask = 0;
> + rule->mask.src_port_mask = 0;
> + rule->mask.src_ipv6_mask = 0;
> + rule->mask.dst_ipv6_mask = 0;
>
> /**
> * The first not void item should be
> --
> 2.34.1
