Hello Harry, On Thu, Oct 6, 2022 at 9:33 PM David Marchand <david.march...@redhat.com> wrote: > > On Thu, Oct 6, 2022 at 3:27 PM Morten Brørup <m...@smartsharesystems.com> > wrote: > > > This commit extends the timeout for service_may_be_active() > > > from 100ms to 1000ms. Local testing on a idle and loaded system > > > (compiling DPDK with all cores) always completes after 1 ms. > > > > > > The wait time for a service-lcore to finish is also extended > > > from 100ms to 1000ms. > > > > > > The same timeout waiting code was duplicated in two tests, and > > > is now refactored to a standalone function avoiding duplication. > > > > > > Reported-by: David Marchand <david.march...@redhat.com> > > > Suggested-by: Mattias Ronnblom <mattias.ronnb...@ericsson.com> > > > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com> > > Acked-by: Morten Brørup <m...@smartsharesystems.com> > Reviewed-by: Mattias Rönnblom <mattias.ronnb...@ericsson.com> > > Ok, let's see if the situation gets better with this. > Applied, thanks.
I took a look at the january month failures at UNH. Downloads/dpdk_31608e4db568_2023-01-03_06-58-00_NA/out/testlog.txt:EAL: Test assert service_lcore_attr_get line 422 failed: Service lcore not stopped after waiting. Extending the timeout just made it less likely. On a similar note, other parts are failing every once in a while: Downloads/dpdk_2a211079a92e_25064_2023-01-24_15-08-50_NA/out/testlog.txt:EAL: Test assert service_attr_get line 319 failed: attr_get() failed to get cycles (expected > zero) Downloads/dpdk_2a211079a92e_25074_2023-01-25_05-40-46_NA/out/testlog.txt:EAL: Test assert service_lcore_start_stop line 900 failed: Service core expected to poll service but it didn't Downloads/dpdk_2a211079a92e_25075_2023-01-25_09-15-58_NA/out/testlog.txt:EAL: Test assert service_lcore_start_stop line 900 failed: Service core expected to poll service but it didn't Downloads/dpdk_373f4c7de8ff_24866_2023-01-03_22-56-01_NA/out/testlog.txt:EAL: Test assert service_lcore_start_stop line 900 failed: Service core expected to poll service but it didn't Downloads/dpdk_83397b9f0739_25030_2023-01-18_18-30-19_NA/out/testlog.txt:EAL: Test assert service_lcore_start_stop line 901 failed: Service core expected to poll service but it didn't The timeout approach just does not have its place in a functional test. Either this test is rewritten, or it must go to the performance tests list so that we stop getting false positives. Can you work on this? Thanks. -- David Marchand
