On 1/24/2023 7:16 AM, Chaoyong He wrote:
> The same data in mask section of different flow add/delete control
> messages will share the same mask ID of mask table. The first flow
> add control message and the last flow delete control message for a
> specific mask ID should have the NFP_FL_META_FLAG_MANAGE_MASK flag set,
> this will indicate to the flower firmware to allocate/deallocate the
> mask table entry.
>
> The original logic wrongly process the flow delete control message,
> and caused the first flow delete control message to have the
> NFP_FL_META_FLAG_MANAGE_MASK flagset, thus the flower firmware
> deallocate the mask table entry on the first delete. This in turn
> prevented all the other flows sharing the same mask ID from offloading.
>
> Fixes: ac09376096d8 ("net/nfp: add structures and functions for flow offload")
> Cc: [email protected]
>
> Signed-off-by: Chaoyong He <[email protected]>
> Reviewed-by: Niklas Söderlund <[email protected]>
Applied to dpdk-next-net/main, thanks.