Hi Thomas, Please see inline.
Thanks, Anoob > Subject: Re: [EXT] Re: [PATCH 1/5] net: add PDCP header > > 18/01/2023 18:39, Anoob Joseph: > > > 22/12/2022 10:25, Anoob Joseph: > > > > --- /dev/null > > > > +++ b/lib/net/rte_pdcp_hdr.h > > > > @@ -0,0 +1,93 @@ > > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > + * Copyright(C) 2022 Marvell. > > > > + */ > > > > + > > > > +#ifndef _RTE_PDCP_HDR_H_ > > > > +#define _RTE_PDCP_HDR_H_ > > > > > > No need of extra underscores before and after. > > > > [Anoob] I was following the example quoted in > https://urldefense.proofpoint.com/v2/url?u=https- > 3A__doc.dpdk.org_guides_contributing_coding- > 5Fstyle.html&d=DwICAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=jPfB8rwwviRSxyL > Ws2n6B-WYLn1v9SyTMrT5EQqh2TU&m=Btr0wWqHo_dHGchyRWTnjO6xY- > 7p33pUSKSBLIXtL4DOAv-GsZmL2lZ2OHyJWoiZ&s=- > AQhSWF0bWFXTyxL0rPCW6fz6I7GYhwyQ9qjYG3FFn0&e= . > > Oh thanks for the reference, I will fix it. > > > Also, other files such as rte_esp.h, rte_udp.h, etc. follow the same. > > Some other files don't have underscores. > > > Isn't it better to have a uniform coding style? > > No really I prefer no underscores, > they are supposed to be used for standard libraries. [Anoob] I see that most of the files do have underscores. While I do not have any personal preference, I would really prefer new code to not stand out from the rest. If you have considered this already, then I'll make the change in next version. Please confirm.
