Hello Thomas, []
> > > > + /** > > > > + * Apply quota verdict - PASS or BLOCK to a flow. > > > > > > Is "to" really wanted here? > > > What about "pass or block a flow"? > > > > > > > The flow action provides information only - it does not affect flow in any > way. > > Application needs to match on quota flow item after quota action to > discover quota state. > > It's also up to application how to react on quota state. > > I am still not sure to understand the comment. > Is this one better? > "Apply the quota verdict (PASS or BLOCK) to a flow." > > Yes. I'll update the v5. > > > > +struct rte_flow_action_quota { > > > > + enum rte_flow_quota_mode mode; /** quota operational mode > */ > > > > + int64_t quota; /** quota value */ > > > > > > What means a negative quota? > > > > Negative quota is kind of a loan extended by a hardware if it provides > such option. > > If quota value is -T, application must provide at least (T+1) tokens to > return quota to PASS state. > > OK. Is it documented? > > I'll add missing documentation.