Hi Bruce,
> -----Original Message-----
> From: Richardson, Bruce <bruce.richard...@intel.com>
> Sent: Tuesday, January 17, 2023 10:04 PM
> To: Jiang, Cheng1 <cheng1.ji...@intel.com>
> Cc: tho...@monjalon.net; m...@smartsharesystems.com; dev@dpdk.org; Hu,
> Jiayu <jiayu...@intel.com>; Ding, Xuan <xuan.d...@intel.com>; Ma, WenwuX
> <wenwux...@intel.com>; Wang, YuanX <yuanx.w...@intel.com>; He,
> Xingguang <xingguang...@intel.com>
> Subject: Re: [PATCH v2] app/dma-perf: introduce dma-perf application
>
> On Tue, Jan 17, 2023 at 01:54:50PM +0000, Jiang, Cheng1 wrote:
> > Hi Bruce,
> >
> > Thanks for your comments.
> > Replies are inline. I'll fix them in the next version.
> >
> > Thanks,
> > Cheng
> >
> > > -----Original Message-----
> > > From: Richardson, Bruce <bruce.richard...@intel.com>
> > > Sent: Tuesday, January 17, 2023 9:00 PM
> > > To: Jiang, Cheng1 <cheng1.ji...@intel.com>
> > > Cc: tho...@monjalon.net; m...@smartsharesystems.com; dev@dpdk.org;
> Hu,
> > > Jiayu <jiayu...@intel.com>; Ding, Xuan <xuan.d...@intel.com>; Ma,
> > > WenwuX <wenwux...@intel.com>; Wang, YuanX <yuanx.w...@intel.com>;
> > > He, Xingguang <xingguang...@intel.com>
> > > Subject: Re: [PATCH v2] app/dma-perf: introduce dma-perf application
> > >
> > > On Tue, Jan 17, 2023 at 01:56:23AM +0000, Cheng Jiang wrote:
>
> <snip>
>
> > > > +#if !defined(RTE_EXEC_ENV_LINUX)
> > > > +
> > > > +int
> > > > +main(int argc, char *argv[])
> > > > +{
> > > > + printf("OS not supported, skipping test\n");
> > > > + return 0;
> > > > +}
> > > > +
> > >
> > > What is linux-specific about this app?
> > >
> > > If we do need to limit the app to Linux-only I suggest using meson
> > > to do so rather than putting #ifdefs in the code.
> >
> > Got it. Thanks!
> >
> Can you maybe clarify what is linux-specific about this app, or else perhaps
> test
> at least building on FreeBSD and windows. I'd rather not see stuff added just
> for
> Linux without some attempt to try on other OS's.
>
> /Bruce
In fact, there is no special reason to only support Linux. I will remove this
restriction. Thanks!
Cheng
