[AMD Official Use Only - General] Hi David
Regarding patch https://patches.dpdk.org/project/dpdk/patch/20221004095132.198777-5-david.march...@redhat.com/ As mentioned earlier, observed floating point exception with using patch. Found issue that cryptodev_cnt variable is not getting updated and set to zero. Please find the below change and share the modified patch, I will ack it. --- a/drivers/crypto/ccp/rte_ccp_pmd.c +++ b/drivers/crypto/ccp/rte_ccp_pmd.c @@ -225,6 +225,8 @@ cryptodev_ccp_create(const char *name, CCP_LOG_ERR("failed to detect CCP crypto device"); goto init_error; } + else + cryptodev_cnt++; CCP_LOG_DBG("CCP : Crypto device count = %d\n", cryptodev_cnt); dev->device = &pci_dev->device; Thanks Sunil -----Original Message----- From: Uttarwar, Sunil Prakashrao Sent: Thursday, January 12, 2023 5:58 PM To: David Marchand <david.march...@redhat.com> Cc: Yigit, Ferruh <ferruh.yi...@amd.com>; Akhil Goyal <gak...@marvell.com>; Namburu, Chandu-babu <cha...@amd.com>; Sebastian, Selwin <selwin.sebast...@amd.com>; dev <dev@dpdk.org>; Thomas Monjalon <tho...@monjalon.net> Subject: RE: [PATCH v2 0/4] crypto/ccp cleanup [AMD Official Use Only - General] Hi David, Please find the below update. Thanks Sunil -----Original Message----- From: David Marchand <david.march...@redhat.com> Sent: Wednesday, January 11, 2023 8:44 PM To: Uttarwar, Sunil Prakashrao <sunilprakashrao.uttar...@amd.com> Cc: Yigit, Ferruh <ferruh.yi...@amd.com>; Akhil Goyal <gak...@marvell.com>; Namburu, Chandu-babu <cha...@amd.com>; Sebastian, Selwin <selwin.sebast...@amd.com>; dev <dev@dpdk.org>; Thomas Monjalon <tho...@monjalon.net> Subject: Re: [PATCH v2 0/4] crypto/ccp cleanup Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Fri, Nov 18, 2022 at 12:58 PM Uttarwar, Sunil Prakashrao <sunilprakashrao.uttar...@amd.com> wrote: > Hi David, > > Please find the below update > > - only one DPDK application can use ccp crypto engines (PCI bus > allow/blocklist is not respected, right?), Yes, only one crypto device can be > used in a DPDK application for the crypto operations. This is introduced from > the patch crypto/ccp: convert driver from vdev to PCI. This is implemented as > per community suggestion. Community suggested to have this driver a standard PCI driver, not a vdev one. I don't remember anything about the limitation. Can you point at the discussion that leaded to this? Sunil -> Please find the discussion about CCP driver as a PCI driver @ https://patches.dpdk.org/project/dpdk/patch/20201225080358.366162-1-asoma...@amd.com/ > > - since only one crypto device is exposed, there is no way for the > application to dedicate/decide how to distribute crypto operations over the > different ccp crypto engines available on the system. > > When there is no ccp device passed from the application > dpdk-test-crypto-perf, it tries to probe all CCP devices present on a system > and only one device can be used. It seems this is bug in the patch > implemented for crypto/ccp: convert driver from vdev to PCI and we are > looking into this. Indeed. So how should we proceed? Patches 1 to 3 are ready and can be merged. I don't mind dropping patch 4 if you have a better solution/alternative. Sunil-> As mentioned earlier, there is some issue with the patch https://patches.dpdk.org/project/dpdk/patch/20221004095132.198777-5-david.march...@redhat.com/. I worked on this patch and found issue. Did change in this patch and observing no issues. Still need some more time test, confirm changes and will share. For now, we can merge below changes, I will ack it. https://patches.dpdk.org/project/dpdk/patch/20221004095132.198777-2-david.march...@redhat.com/ https://patches.dpdk.org/project/dpdk/patch/20221004095132.198777-3-david.march...@redhat.com/ https://patches.dpdk.org/project/dpdk/patch/20221004095132.198777-4-david.march...@redhat.com/ We will merge the below patch once we fix it with modifications https://patches.dpdk.org/project/dpdk/patch/20221004095132.198777-5-david.march...@redhat.com/ Please let me know if any suggestions. -- David Marchand
