On Wed, Jan 11, 2023 at 12:06:26PM +0000, Chengwen Feng wrote:
> The stats reset is useful for debugging, so add it to the dmadev
> telemetry command lists.
>
> Signed-off-by: Chengwen Feng <fengcheng...@huawei.com>
Looks ok to me, just one small comment inline. With that fixed:
Reviewed-by: Bruce Richardson <bruce.richard...@intel.com>
> ---
> lib/dmadev/rte_dmadev.c | 46 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c
> index 4da653eec7..79593cdbe2 100644
> --- a/lib/dmadev/rte_dmadev.c
> +++ b/lib/dmadev/rte_dmadev.c
> @@ -994,6 +994,50 @@ dmadev_handle_dev_stats(const char *cmd __rte_unused,
> return 0;
> }
>
> +static int
> +dmadev_handle_dev_stats_reset(const char *cmd __rte_unused,
> + const char *params,
> + struct rte_tel_data *d)
> +{
> + struct rte_dma_info dma_info;
> + int dev_id, ret, vchan_id;
> + const char *vchan_param;
> + char *end_param;
> +
> + if (params == NULL || strlen(params) == 0 || !isdigit(*params))
> + return -EINVAL;
> +
> + dev_id = strtoul(params, &end_param, 0);
> +
> + /* Function info_get validates dev_id so we don't need to. */
> + ret = rte_dma_info_get(dev_id, &dma_info);
> + if (ret < 0)
> + return -EINVAL;
> +
> + /* If the device has one vchan the user does not need to supply the
> + * vchan id and only the device id is needed, no extra parameters.
> + */
> + if (dma_info.nb_vchans == 1 && *end_param == '\0')
> + vchan_id = 0;
> + else {
> + vchan_param = strtok(end_param, ",");
> + if (!vchan_param || strlen(vchan_param) == 0 ||
> !isdigit(*vchan_param))
> + return -EINVAL;
> +
> + vchan_id = strtoul(vchan_param, &end_param, 0);
> + }
> + if (*end_param != '\0')
> + RTE_DMA_LOG(WARNING, "Extra parameters passed to dmadev
> telemetry command, ignoring");
> +
> + ret = rte_dma_stats_reset(dev_id, vchan_id);
> + if (ret == 0) {
> + rte_tel_data_start_dict(d);
This line is unnecessary. "rte_tel_data_string" below sets the overall
datatype as "string", replacing the "dict" type set here. To set the string
inside the dict you have just created use "rte_tel_data_add_dict_string".
[Note: the data returned from a command is always put in a json dict
automatically - that is separate from any dict initialized here.]
> + rte_tel_data_string(d, "success");
> + }
> +
> + return ret;
> +}
> +
> #ifndef RTE_EXEC_ENV_WINDOWS
> static int
> dmadev_handle_dev_dump(const char *cmd __rte_unused,
> @@ -1041,6 +1085,8 @@ RTE_INIT(dmadev_init_telemetry)
> "Returns information for a dmadev. Parameters: int
> dev_id");
> rte_telemetry_register_cmd("/dmadev/stats", dmadev_handle_dev_stats,
> "Returns the stats for a dmadev vchannel. Parameters:
> int dev_id, vchan_id (Optional if only one vchannel)");
> + rte_telemetry_register_cmd("/dmadev/stats_reset",
> dmadev_handle_dev_stats_reset,
> + "Reset the stats for a dmadev vchannel. Parameters: int
> dev_id, vchan_id (Optional if only one vchannel)");
> #ifndef RTE_EXEC_ENV_WINDOWS
> rte_telemetry_register_cmd("/dmadev/dump", dmadev_handle_dev_dump,
> "Returns dump information for a dmadev. Parameters: int
> dev_id");
> --
> 2.17.1
>
