Hi Nicolas,

On 1/4/23 19:01, Chautru, Nicolas wrote:
Hi Maxime,

I don’t see them on the baseband tree  dpdk-next-baseband

I did a clean clone, these are the last 3 commits
   dc0a5a0d2a (HEAD -> for-main, origin/for-main) test/bbdev: explicit check 
for allocation failure
   0e927787a3 test/bbdev: fix build issue with optional build flag
   51d49ccd23 test/bbdev: fix build issue with optional build flag

I don’t see the last 3 commits from patchwork (ie. the serie from that email)
   [v1,3/3] app/bbdev-test: remove offload cost optional build flag     bbdev: 
remove offload cost      - - -   3--     2022-12-14      Chautru, Nicolas       
 mcoquelin       Awaiting Upstream
   [v1,2/3] drivers/baseband: remove offload cost optional build flag   bbdev: 
remove offload cost      - - -   1--     2022-12-14      Chautru, Nicolas       
 mcoquelin       Awaiting Upstream
   [v1,1/3] test/bbdev: explicit check for allocation failure   bbdev: remove 
offload cost      - - -   11-     2022-12-14      Chautru, Nicolas        
mcoquelin       Awaiting Upstream
[v3,3/3] test/bbdev: explicit check for allocation failure      test/bbdev: fix 
build issues with optional build flag   - 1 -   10--    2022-12-13      
Chautru, Nicolas        mcoquelin       Awaiting Upstream
[v3,2/3] test/bbdev: fix build issue with optional build flag   test/bbdev: fix 
build issues with optional build flag   - 1 -   1--     2022-12-13      
Chautru, Nicolas        mcoquelin       Awaiting Upstream
[v3,1/3] test/bbdev: fix build issue with optional build flag   test/bbdev: fix 
build issues with optional build flag   - 1 -   11-     2022-12-13      
Chautru, Nicolas        mcoquelin       Awaiting Upstream

Do I miss something? This last serie doesn’t look applied on the remote repo. 
Could you double check?

Hmm OK, I think I got mislead by the similarity of the commit titles
between the two series when I changed the state of the first series.

I'm reverting back the state of this series from "Awaiting upstream" to
"New" since I have not reviewed this one yet. I'll try to review it
before end of week.

Thanks for the heads-up!
Maxime

Thanks
Nic


-----Original Message-----
From: Maxime Coquelin <maxime.coque...@redhat.com>
Sent: Wednesday, January 4, 2023 4:43 AM
To: Chautru, Nicolas <nicolas.chau...@intel.com>; dev@dpdk.org
Cc: Vargas, Hernan <hernan.var...@intel.com>
Subject: Re: [PATCH v1 0/3] bbdev: remove offload cost

Hi Nicolas,

On 1/3/23 23:07, Chautru, Nicolas wrote:
Hi Maxime,

Happy new year.

Happy new year.

What does the state " Awaiting Upstream" mean in patchwork for that
serie? Can this be applied?

It means it is the the bbdev tree, and is awaiting being pulled into the main
tree.

So it is applied, but only in the bbdev tree for now.
This should not be an issue since you shold base your work on top of the
bbdev tree.

Regards,
Maxime

Thanks
Nic



-----Original Message-----
From: Chautru, Nicolas <nicolas.chau...@intel.com>
Sent: Wednesday, December 14, 2022 3:34 PM
To: dev@dpdk.org; maxime.coque...@redhat.com
Cc: Vargas, Hernan <hernan.var...@intel.com>; Chautru, Nicolas
<nicolas.chau...@intel.com>
Subject: [PATCH v1 0/3] bbdev: remove offload cost

Removing the optional build flag RTE_BBDEV_OFFLOAD_COST from Intel
baseband PMDs and bbdev-test application.
This helps to simplify build variants complexity causing compilation
issues to be missed.

Maxime, the first commit is actually a miss related to last commit on
top of tree, you may want to merge these two commits together in the
history.
Sorry for missing it earlier.


Nicolas Chautru (3):
    test/bbdev: explicit check for allocation failure
    drivers/baseband: remove offload cost optional build flag
    app/bbdev-test: remove offload cost optional build flag

   app/test-bbdev/test_bbdev_perf.c              | 29 +-------
   drivers/baseband/acc/acc_common.h             | 12 +---
   drivers/baseband/acc/rte_acc100_pmd.c         |  2 -
   drivers/baseband/acc/rte_acc200_pmd.c         |  2 -
   .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c         | 10 ---
   drivers/baseband/fpga_lte_fec/fpga_lte_fec.c  | 10 ---
   .../baseband/turbo_sw/bbdev_turbo_software.c  | 70 ++++---------------
   7 files changed, 17 insertions(+), 118 deletions(-)

--
2.34.1



Reply via email to