Konstantin Ananyev, Dec 22, 2022 at 13:41: > > +static rte_lcore_usage_cb lcore_usage_cb; > > + > > +void > > +rte_lcore_register_usage_cb(rte_lcore_usage_cb cb) > > +{ > > + lcore_usage_cb = cb; > > +} > > + > > LGTM in general. > One question: I assume this function is supposed to be called just > once at app init stage, so we probably don't need to worry about > possible sync issues, right? If so, then probably worth to mention it > in the function formal comments below.
Yes, this is correct. I'll add a mention in the function docstring to explain that this should be called once at init. Also I'll add a comment in the function body to indicate that there is no risk of sync issues.