On Tue, Dec 6, 2022 at 1:39 AM Tyler Retzlaff <roret...@linux.microsoft.com> wrote: > > Memory configuration was not being marked as completed add the missing > call to rte_eal_init() for Windows. > > Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com>
The change is ok. The commitlog misses some context: I guess the point is to let rte_thread_register work on Windows. So we can mark this change as: Fixes: 5c307ba2a5b1 ("eal: register non-EAL threads as lcores") WDYT? In any case, this change won't fix anything related to mp. If mp is supported one day on Windows, other calls to eal_mcfg* would be required. -- David Marchand