On 12/7/2022 3:43 PM, Ferruh Yigit wrote:
> On 12/7/2022 2:41 PM, Junxiao Shi wrote:
>> This allows a DPDK application running with root privilege to create a
>> memif socket listener with non-root owner uid and gid, which can be
>> connected from client applications running without root privilege.
>>
>
> Do you have an easy way to test unprivileged memif client?
>
>> Signed-off-by: Junxiao Shi <g...@mail1.yoursunny.com>
>
> <...>
>
>> @@ -1827,47 +1859,58 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev)
>> flags |= ETH_MEMIF_FLAG_SOCKET_ABSTRACT;
>>
>> kvlist = rte_kvargs_parse(rte_vdev_device_args(vdev), valid_arguments);
>> + if (kvlist == NULL) {
>> + MIF_LOG(ERR, "Invalid kvargs key");
>> + ret = -EINVAL;
>> + goto exit;
>> + }
>
> Thanks Junxiao for updating this, but since it is not really related to
> this patch, can you please separate it to another patch?
Also I am not sure what 'rte_kvargs_parse()' returns if there is no
argument provided (that may be the case if all default values are desired).
If API returns NULL for that case, above error log can be wrong, can you
please check.
