Hi Ganapti, > -----Original Message----- > From: Kundapura, Ganapati <ganapati.kundap...@intel.com> > Sent: Wednesday, November 30, 2022 10:40 PM > To: dev@dpdk.org; jer...@marvell.com; Naga Harish K, S V > <s.v.naga.haris...@intel.com>; Gujjar, Abhinandan S > <abhinandan.guj...@intel.com> > Cc: Jayatheerthan, Jay <jay.jayatheert...@intel.com> > Subject: [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count stats
As per the DPDK contribute guidelines, the subject line should use the imperative of the verb (like instructions to the code base). http://doc.dpdk.org/guides/contributing/patches.html Please change the subject lines for all patches in the patch set wherever it is required. Also is it optimizing the stats update or fixing wrong stats update? > > crypto_enq_count is updated on failure to enqueue ops to cryptodev. > > Updated crypto_enq_count on successful enqueue of ops to cryptodev. > > Signed-off-by: Ganapati Kundapura <ganapati.kundap...@intel.com> > > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > b/lib/eventdev/rte_event_crypto_adapter.c > index 1c0a22b..ef3dbe9 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.c > +++ b/lib/eventdev/rte_event_crypto_adapter.c > @@ -485,6 +485,9 @@ eca_enq_to_cryptodev(struct event_crypto_adapter > *adapter, struct rte_event *ev, > cdev_id, > qp_id, > > &nb_enqueued); > + stats->crypto_enq_count += nb_enqueued; > + n += nb_enqueued; > + > /** > * If some crypto ops failed to flush to cdev and > * space for another batch is not available, stop @@ - > 495,9 +498,6 @@ eca_enq_to_cryptodev(struct event_crypto_adapter > *adapter, struct rte_event *ev, > &qp_info->cbuf))) > adapter->stop_enq_to_cryptodev = true; > } > - > - stats->crypto_enq_count += nb_enqueued; > - n += nb_enqueued; > } > > return n; > -- > 2.6.4
