> -----Original Message-----
> From: Singh, Aman Deep <aman.deep.si...@intel.com>
> Sent: Monday, November 7, 2022 12:42 PM
> To: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>; Yuying Zhang
> <yuying.zh...@intel.com>; Cristian Dumitrescu
> <cristian.dumitre...@intel.com>
> Cc: dev@dpdk.org; Sunil Kumar Kori <sk...@marvell.com>
> Subject: [EXT] Re: [PATCH v2 1/3] app/testpmd: support congestion
> management CLIs
>
> External Email
>
> ----------------------------------------------------------------------
> These newly added files for Congestion Management look in-line to Traffic
> Metering part, would like @Cristian to also have a look.
>
> Regards
> Aman
>
> On 11/6/2022 3:38 PM, Andrew Rybchenko wrote:
> > @Aman, @Yuying, please, help to review the patch.
> >
> > On 10/12/22 12:01, Sunil Kumar Kori wrote:
> >> Please review the following changes and provide feedback.
> >>
> >> Regards
> >> Sunil Kumar Kori
> >>
> >>> -----Original Message-----
> >>> From: sk...@marvell.com <sk...@marvell.com>
> >>> Sent: Thursday, September 29, 2022 3:25 PM
> >>> To: Aman Singh <aman.deep.si...@intel.com>; Yuying Zhang
> >>> <yuying.zh...@intel.com>
> >>> Cc: dev@dpdk.org; Sunil Kumar Kori <sk...@marvell.com>
> >>> Subject: [PATCH v2 1/3] app/testpmd: support congestion management
> >>> CLIs
> >>>
> >>> From: Sunil Kumar Kori <sk...@marvell.com>
> >>>
> >>> Support congestion management CLIs.
> >>>
> >>> Depends-on: patch-24902 ("ethdev: support congestion management")
> >>>
> >>> Signed-off-by: Sunil Kumar Kori <sk...@marvell.com>
> Acked-by: Aman Singh <aman.deep.si...@intel.com>
> >>> ---
> >>> v1..v2:
> >>> - Rebase on top of the dpdk-next-net-mrvl/for-next-net
> >>>
> >>> app/test-pmd/cmdline.c | 15 +
> >>> app/test-pmd/cmdline_cman.c | 390
> >>> ++++++++++++++++++++
> >>> app/test-pmd/cmdline_cman.h | 12 +
> >>> app/test-pmd/meson.build | 1 +
> >>> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 26 ++
> >>> 5 files changed, 444 insertions(+)
> >>> create mode 100644 app/test-pmd/cmdline_cman.c create mode
> 100644
[snipped]
> >>>
> >>> +Congestion Management
> >>> +---------------------
> >>> +
> >>> +Get capabilities
> >>> +~~~~~~~~~~~~~~~~
> >>> +
> >>> +Retrieve congestion management capabilities supported by driver for
> >>> given
> >>> port.
> >>> +Below example command retrieves capabilities for port 0::
> >>> +
> >>> + testpmd> show port cman capa 0
> >>> +
> >>> +Get configuration
> >>> +~~~~~~~~~~~~~~~~~
> >>> +Retrieve congestion management configuration for given port. Below
> >>> +example command retrieves configuration for port 0::
> >>> +
> >>> + testpmd> show port cman config 0
> >>> +
> >>> +Set configuration
> >>> +~~~~~~~~~~~~~~~~~
> >>> +Configures congestion management settings on given queue or
> mempool
> >>> +associated with queue. Below example command configures RED as
> >>> +congestion management algo for port 0 and queue 0::
> >>> +
> >>> + testpmd> set port cman config 0 0 obj queue mode red 10 100 1
> >>> +
> Rather than adding this section at the end can we put it near TM section 4.9
Ack. But I believe keeping it after section 4.10 is okay.
> >>> Driver specific commands
> >>> ------------------------
> >>>
> >>> --
> >>> 2.25.1
> >>
> >
