> From: Luca Boccassi [mailto:luca.bocca...@gmail.com] > Sent: Monday, 28 November 2022 12.55 > > On Mon, 28 Nov 2022 at 11:35, Morten Brørup <m...@smartsharesystems.com> > wrote: > > > > +CC Andrew Rybchenko as co-signer on the mempool patch in mainline. > > > > > From: luca.bocca...@gmail.com [mailto:luca.bocca...@gmail.com] > > > Sent: Monday, 28 November 2022 11.53
[...] > > > mempool: fix get objects from mempool with cache > > > > Reviewed stable release patch [1], comparing it to the accepted > mainline patch [2]. > > > > [1]: https://git.dpdk.org/dpdk- > stable/commit/?h=20.11&id=26cb4c81b552594292f7c744afb904f01700dfe8 > > [2]: > https://patchwork.dpdk.org/project/dpdk/patch/20221007104450.2567961-1- > andrew.rybche...@oktetlabs.ru/ > > > > This is not correct: > > + __MEMPOOL_STAT_ADD(mp, get_success_bulk, 1); > > + __MEMPOOL_STAT_ADD(mp, get_success_objs, n); > > > > The old macro did more, so it should be: > > + __MEMPOOL_STAT_ADD(mp, get_success, n); > > > > This is only visible if built with RTE_LIBRTE_MEMPOOL_DEBUG. > > > > Besides that, it looks perfectly good to me. > > Can you test a patch and send it? Extremely busy these days... Not sure I can make it within the deadline. Alternatively, consider omitting the patch. It only fixes some performance issues for certain use cases. -Morten
