On Fri, 25 Nov 2022 19:16:00 -0800 Rushil Gupta <rush...@google.com> wrote:
> > > > > > The driver should be filling in the per-queue stats as well. > > > q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors > > > > > > Hi Stephen, > > > > Queue stats moved to xstats, and there is a long term goal to move all > > queue stats from basic stats to xstats for all PMDs, and remove interim > > 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. > > > > That is why request to new PMDs is to not introduce queue stats in basic > > stats, but in xstats. Agree that xstats are better but: * the current checked in version of GVE does not have driver op for xstats * if driver fills in the q_XXX[] stats then eth_dev_get_xstats_basic will be able to use it. The per queue stats are limited to 256 queues and bloats the info structure, but until an API breaking change is made to remove them, drivers should support it.
