29/09/2022 14:04, Olivier Matz: > When passing the patch to checkpatches.sh through stdin, the subject is > retrieved by reading the input until a "Subject:" entry is found. The > rest of the input is piped to checkpatch.pl. > > Since the "From:" line is before the "Subject:" line, it won't be sent to > checkpatch.pl, which won't be able to get the author of the commit. > The following error will appear: > > > ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > > author '' > > Do the subject lookup on the temporary file instead of stdin, and > send the whole lines to checkpatch.pl. > > The problem is visible since the introduction of this check in linux > checkpatch.pl in version 4.19 (see link below). > > Link: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cd2614967d8b > Fixes: 8005feef421d ("scripts: add standard input to checkpatch") > CC: sta...@dpdk.org > > Signed-off-by: Olivier Matz <olivier.m...@6wind.com> Reviewed-by: Thomas Monjalon <tho...@monjalon.net>
Applied, thanks.
