Currently, one rte_flow may be split to multiple sub mlx5_flows.
While GENEVE option resource was allocated in the first mlx5_flow,
the flag will be overwritten by next sub mlx5_flow. This caused
GENEVE option resource leakage.
This commit adds the check of GENEVE option resource to avoid the
GENEVE option flag be overwritten.
Fixes: cd4ab742064a ("net/mlx5: split flow item matcher and value translation")
Signed-off-by: Suanming Mou <suanmi...@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viachesl...@nvidia.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 62c38b87a1..7ca909999b 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -13717,7 +13717,12 @@ flow_dv_translate_items_sws(struct rte_eth_dev *dev,
* is the suffix flow.
*/
dev_flow->handle->layers |= wks.item_flags;
- dev_flow->flow->geneve_tlv_option = wks.geneve_tlv_option;
+ /*
+ * Update geneve_tlv_option flag only it is set in workspace.
+ * Avoid be overwritten by other sub mlx5_flows.
+ */
+ if (wks.geneve_tlv_option)
+ dev_flow->flow->geneve_tlv_option = wks.geneve_tlv_option;
return 0;
}
--
2.25.1
