2015-11-02 10:36, Iremonger, Bernard: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2015-10-30 15:08, Bernard Iremonger: > > > add dev_flags to rte_eth_dev_data, add macros for dev_flags. > > > add kdrv to rte_eth_dev_data. > > > add numa_node to rte_eth_dev_data. > > > add drv_name to rte_eth_dev_data. > > > > A commit message should explain why things are done. > > > > > + uint32_t dev_flags; /**< Flags controlling handling of device. */ > > > > Where are defined this flags? What is the scope? > > These flags are defined in the following file: > > lib/librte_ether/rte_ethdev.h > > These flags are visible to all the vdevs and pdevs.
I mean it should be more explicit. Having an enum name will help. Note: I understand your patch. I'm just asking the questions an user will ask when trying to use your new API. Thanks
