> -----Original Message-----
> From: humin (Q) <humi...@huawei.com>
> Sent: Tuesday, November 1, 2022 10:21 AM
> To: Ivan Malov <ivan.ma...@oktetlabs.ru>; dev@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx...@intel.com>; Chas Williams <ch...@att.com>;
> Hari Kumar Vemula <hari.kumarx.vem...@intel.com>; sta...@dpdk.org;
> Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
> Subject: Re: [PATCH] net/bonding: set initial value of descriptor count
> alignment
> 
> Acked-by: Min Hu (Connor) <humi...@huawei.com>
> 
> 在 2022/10/31 21:17, Ivan Malov 写道:
> > The driver had once been broken by patch [1] looking to have a
> > non-zero "nb_max" value in a use case not involving adding any
> > back-end ports. That was addressed afterwards ([2]). But, as per
> > report [3], similar test cases exist which attempt to setup Rx queues
> > on a void bond before attaching any back-end ports. Rx queue setup, in
> > turn, involves device info get API invocation, and one of the checks
> > on received data causes an exception (division by zero). The
> > "nb_align" value is indeed zero at that time, but, as explained in
> > [2], such test cases are totally incorrect since a bond device must
> > have at least one back-end port plugged before any ethdev APIs can be
> > used.
> >
> > Once again, to avoid any problems with fixing the test cases, this
> > patch adjusts the bond PMD itself to workaround the bug.
> >
> > [1] commit 5be3b40fea60 ("net/bonding: fix values of descriptor
> > limits") [2] commit d03c0e83cc00 ("net/bonding: fix descriptor limit
> > reporting") [3] https://bugs.dpdk.org/show_bug.cgi?id=1118
> >
> > Fixes: d03c0e83cc00 ("net/bonding: fix descriptor limit reporting")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Ivan Malov <ivan.ma...@oktetlabs.ru>
> > Reviewed-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
> > ---
Tested-by: Weiyuan Li <weiyuanx...@intel.com>

This patch needs to be applied additionally 
https://patches.dpdk.org/project/dpdk/patch/20221101161853.2702425-1-ivan.ma...@oktetlabs.ru/
  can be verified to pass

Reply via email to