> -----Original Message----- > From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > Sent: Saturday, October 29, 2022 10:48 PM > To: Xing, Beilei <beilei.x...@intel.com>; Wu, Jingjing <jingjing...@intel.com> > Cc: dev@dpdk.org; Thomas Monjalon <tho...@monjalon.net> > Subject: Re: [PATCH v15 00/18] add support for idpf PMD in DPDK > > On 10/29/22 06:27, beilei.x...@intel.com wrote: > > From: Beilei Xing <beilei.x...@intel.com> > > > > This patchset introduced the idpf (Infrastructure Data Path Function) PMD > in DPDK for Intel® IPU E2000 (Device ID: 0x1452). > > The Intel® IPU E2000 targets to deliver high performance under real > workloads with security and isolation. > > Please refer to > > https://www.intel.com/content/www/us/en/products/network- > io/infrastruc > > ture-processing-units/asic/e2000-asic.html > > for more information. > > > > Linux upstream is still ongoing, previous work refers to > https://patchwork.ozlabs.org/project/intel-wired- > lan/patch/20220128001009.721392-20-alan.br...@intel.com/. > > > > v2-v4: > > fixed some coding style issues and did some refactors. > > > > v5: > > fixed typo. > > > > v6-v9: > > fixed build errors and coding style issues. > > > > v11: > > - move shared code to common/idpf/base > > - Create one vport if there's no vport devargs > > - Refactor if conditions according to coding style > > - Refactor virtual channel return values > > - Refine dev_stop function > > - Refine RSS lut/key > > - Fix build error > > > > v12: > > - Refine dev_configure > > - Fix coding style according to the comments > > - Re-order patch > > - Romove dev_supported_ptypes_get > > > > v13: > > - refine dev_start/stop and queue_start/stop > > - fix timestamp offload > > > > v14: > > - fix wrong position for rte_validate_tx_offload > > > > v15: > > - refine the return value for ethdev ops. > > - removce forward static declarations. > > - refine get caps. > > - fix lock/unlock handling. > > Applied to dpdk-next-net/main, thanks. > > I've a number of concerns: > * conditional compilation IDPF_RX_PTYPE_OFFLOAD in [PATCH v15 17/18]
Will remove the conditional compilation > net/idpf: add AVX512 data path for single queue model > * the same prefix used for functions in common/idpf/base and net/idpf > drivers I think the name of PMD and common library can be the same, right? > * common/idpf/base uses own defines for negative errno (defined as a > number with corresponding errno in a comment). Strictly speaking it is not > the same, but work fine in a majority of cases Make sense, will remove the own defines. Thanks for your review, I saw the status in patchwork has been accepted, but didn't see idpf in dpdk-next-net, will send v16 to address the comments first. > > So, final decision will be done by Thomas on pulling to main tree.
