On 10/27/2022 8:58 AM, David Marchand wrote:
On Thu, Oct 20, 2022 at 1:52 PM Ferruh Yigit <ferruh.yi...@amd.com> wrote:
Honestly I think the status quo is OK:
We have some aliases in some PMD for some historical reason
and everybody looks OK with that. Isn't it?


Well, the inconsistency bugs me a little, but if others feel the status quo
is ok, I'm ok with that.

In my perspective this is for cleanup, and new PMDs keep adding alias
because they are copying from existing drivers.
Except from above there is no harm to have alias.

Do we have a "valid" case of adding new aliases?
I don't think it is the case, so we can warn of new aliases
introduction in checkpatches.sh.


I commented a few of them to drop alias.
checkpatch can be an option, but my intention was to drop old code to reduce noise, not to add more :)

OK to keep the alias if removing it will cause more trouble.

At worse, if a valid case is identified later, checkpatches.sh is only
a warning in patchwork and maintainers will manually review this
warning.



Reply via email to