On 10/26/22 22:16, Andrew Rybchenko wrote:
>
> On 10/19/22 17:49, Michael Baum wrote:
> > When application use queue-based flow rule management and operate the
> > same flow rule on the same queue, e.g create/destroy/query, API of
> > querying aged flow rules should also have queue id parameter just like
> > other queue-based flow APIs.
> >
> > By this way, PMD can work in more optimized way since resources are
> > isolated by queue and needn't synchronize.
> >
> > If application do use queue-based flow management but configure port
> > without RTE_FLOW_PORT_FLAG_STRICT_QUEUE, which means application
> > operate a given flow rule on different queues, the queue id parameter
> > will be ignored.
> >
> > Signed-off-by: Michael Baum <michae...@nvidia.com>
> > Acked-by: Ori Kam <or...@nvidia.com>
>
> Few minor notes below, other than that
>
> Acked-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
>
Thank you, I'm sending a new version without unrelated fixes.
I'll send them later in a different patch set.
> [snip]
>
> > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > index a8b99c8c19..8e21b2a5b7 100644
> > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > @@ -2894,9 +2894,10 @@ following sections.
> > [meters_number {number}] [flags {number}]
> >
> > - Create a pattern template::
> > +
>
> unrelated style fixes, should be in a separate patch
>
> > flow pattern_template {port_id} create [pattern_template_id {id}]
> > [relaxed {boolean}] [ingress] [egress] [transfer]
> > - template {item} [/ {item} [...]] / end
> > + template {item} [/ {item} [...]] / end
>
> unrelated style fixes
>
> >
> > - Destroy a pattern template::
> >
> > @@ -2995,6 +2996,10 @@ following sections.
> >
> > flow aged {port_id} [destroy]
> >
> > +- Enqueue list and destroy aged flow rules::
> > +
> > + flow queue {port_id} aged {queue_id} [destroy]
> > +
> > - Tunnel offload - create a tunnel stub::
> >
> > flow tunnel create {port_id} type {tunnel_type} @@ -4236,7
> > +4241,7 @@ Disabling isolated mode::
> > testpmd>
> >
> > Dumping HW internal information
> > -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> unrelated changes
>
> >
> > ``flow dump`` dumps the hardware's internal representation information of
> > all flows. It is bound to ``rte_flow_dev_dump()``::
> > @@ -4252,10 +4257,10 @@ Otherwise, it will complain error occurred::
> > Caught error type [...] ([...]): [...]
> >
> > Listing and destroying aged flow rules
> > -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > ``flow aged`` simply lists aged flow rules be get from api
> > ``rte_flow_get_aged_flows``, -and ``destroy`` parameter can be used to
> destroy those flow rules in PMD.
> > +and ``destroy`` parameter can be used to destroy those flow rules in PMD::
>
> unrelated style fixes
>
> >
> > flow aged {port_id} [destroy]
> >
> > @@ -4290,7 +4295,7 @@ will be ID 3, ID 1, ID 0::
> > 1 0 0 i--
> > 0 0 0 i--
> >
> > -If attach ``destroy`` parameter, the command will destroy all the list aged
> flow rules.
> > +If attach ``destroy`` parameter, the command will destroy all the list aged
> flow rules::
>
> unrelated style fixes
>
> [snip]
