Hi, > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, November 2, 2015 7:59 AM > > + /* if xstats_get() is implemented by the PMD, the Q stats are done > > */ > > + if (dev->dev_ops->xstats_get != NULL) > > + return count + xcount; > > + > > /* per-rxq stats */ > > for (q = 0; q < dev->data->nb_rx_queues; q++) { > > for (i = 0; i < RTE_NB_RXQ_STATS; i++) { > > Please could you explain why the generic per-queue stats are not used when > xstats is implemented in the driver?
Each PMD exposes its own queue stats so it has the flexibility of presenting them exactly has the hardware counts, in a human-readable order. If the generic xstats were used, testpmd> xstats output would split a single queue's xstats to two places in the list. As stats are used during debugging, readability and clarity of the stats is vital in my opinion. -Harry
